Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: clang17 compile error #85

Merged
merged 1 commit into from
Oct 24, 2024
Merged

bugfix: clang17 compile error #85

merged 1 commit into from
Oct 24, 2024

Conversation

LHT129
Copy link
Collaborator

@LHT129 LHT129 commented Oct 23, 2024 •
edited
Loading

fixed: #86

@LHT129 LHT129 added the kind/bug Something isn't working label Oct 23, 2024
@LHT129 LHT129 requested review from wxyucs and inabao October 23, 2024 10:04
@LHT129 LHT129 self-assigned this Oct 23, 2024
@LHT129 LHT129 requested a review from jiaweizone as a code owner October 23, 2024 10:04
inabao
inabao approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@inabao inabao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wxyucs
wxyucs approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LHT129
bugfix: clang17 compile error
de2cd42 
Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
jiaweizone
jiaweizone approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@jiaweizone jiaweizone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LHT129 LHT129 merged commit 7158891 into antgroup:main Oct 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inabao inabao inabao approved these changes

@wxyucs wxyucs wxyucs approved these changes

@jiaweizone jiaweizone jiaweizone approved these changes

Assignees

@LHT129 LHT129

Labels
kind/bug Something isn't working size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

initializing a reference to nullptr will cause compilation to fail in Clang 17
4 participants
@LHT129 @jiaweizone @wxyucs @inabao