use parallel for ci_test #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
LHT129
commented
Oct 24, 2024
•
LHT129
commented
- introduce Makefile new tag: test_asan_parallel
- mark [diskann] & [hnsw] tags run parallel
LHT129
added
the
kind/improvement
LHT129
force-pushed
the
shard_test
branch
2 times, most recently
from
1ce403b to
08696f1
Compare
jiaweizone
reviewed
Oct 25, 2024
src/bitset_impl_test.cpp
Outdated
| @@ -22,6 +22,10 @@ | |||
|
|
|||
| using namespace roaring; | |||
|
|
|||
| TEST_CASE("false") { | |||
| REQUIRE(1 == 0); | |||
There was a problem hiding this comment.
force failure this task ?
There was a problem hiding this comment.
just for test. remove now
LHT129
force-pushed
the
shard_test
branch
4 times, most recently
from
0160a2e to
51172e9
Compare
inabao
approved these changes
Oct 28, 2024
jiaweizone
reviewed
Oct 28, 2024
test_asan_bg.sh
Outdated
| exit_codes+=($?) | ||
| done | ||
|
|
||
| all_successful=true |
There was a problem hiding this comment.
here can direct return exit_codes ?
There was a problem hiding this comment.
exit codes is an array. we may add some logger to detail which case fail in future
wxyucs
reviewed
Oct 31, 2024
- introduce Makefile new tag: test_asan_parallel - mark [diskann] & [hnsw] tags run parallel Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
|
lgtm |
wxyucs
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.