add graph_datacell and sparse_graph_datacell #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LHT129
force-pushed
the
graph_datacell
branch
3 times, most recently
from
bc3dfbe to
68ac1da
Compare
wxyucs
requested changes
Oct 31, 2024
LHT129
force-pushed
the
graph_datacell
branch
12 times, most recently
from
b64b58a to
694bb38
Compare
wxyucs
requested changes
Nov 1, 2024
LHT129
force-pushed
the
graph_datacell
branch
2 times, most recently
from
0b8c3da to
c8f2436
Compare
LHT129
force-pushed
the
graph_datacell
branch
from
c8f2436 to
c7a4d08
Compare
jiaweizone
reviewed
Nov 4, 2024
src/data_cell/graph_datacell.h
Outdated
| }; | ||
|
|
||
| template <typename IOTmpl> | ||
| GraphDataCell<IOTmpl, false>::GraphDataCell(const JsonType& graph_json_params, |
There was a problem hiding this comment.
minor: graph_json_params and simply to graph_params
src/data_cell/graph_interface.cpp
Outdated
| namespace vsag { | ||
|
|
||
| GraphInterfacePtr | ||
| GraphInterface::MakeInstance(const JsonType& json_obj, |
There was a problem hiding this comment.
json_obj -> build_conf / build_params ?
src/data_cell/graph_interface.cpp
Outdated
| return std::make_shared<GraphDataCell<MemoryBlockIO, false>>( | ||
| graph_param, io_param, common_param); | ||
| } | ||
| if (io_string == IO_TYPE_VALUE_MEMORY_IO) { |
|
|
||
| namespace vsag { | ||
|
|
||
| SparseGraphDataCell::SparseGraphDataCell(const JsonType& graph_json_params, |
There was a problem hiding this comment.
simply to graph_params ?
|
|
||
| SparseGraphDataCell::SparseGraphDataCell(const JsonType& graph_json_params, | ||
| const IndexCommonParam& common_param) | ||
| : allocator_(common_param.allocator_), neighbors_(allocator_) { |
There was a problem hiding this comment.
minor: Here depends the fields initialize sequence
can change to: neighbors_(common_param.allocator_)
- graph_datacell for bottom graph - sparse_graph_datacell for high level graph Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
LHT129
force-pushed
the
graph_datacell
branch
from
c7a4d08 to
98c0a3a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #40