Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update temp_dir struct #97

Merged
merged 1 commit into from
Oct 30, 2024
Merged

update temp_dir struct #97

merged 1 commit into from
Oct 30, 2024

Conversation

LHT129
Copy link
Collaborator

@LHT129 LHT129 commented Oct 28, 2024

  • add generate file func
  • try again if same dir/file exists

@LHT129 LHT129 added the kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) label Oct 28, 2024
@LHT129 LHT129 self-assigned this Oct 28, 2024
@LHT129
update temp_dir struct
2d3c1b6 
- add generate file func
- try again if same dir/file exists

Signed-off-by: LHT129 <tianlan.lht@antgroup.com>
jiaweizone
jiaweizone approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@jiaweizone jiaweizone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

inabao
inabao approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@inabao inabao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LHT129 LHT129 merged commit 3b1f758 into antgroup:main Oct 30, 2024
2 checks passed
@LHT129 LHT129 deleted the update_test_dir branch January 17, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inabao inabao inabao approved these changes

@jiaweizone jiaweizone jiaweizone approved these changes

@ShawnShawnYou ShawnShawnYou Awaiting requested review from ShawnShawnYou ShawnShawnYou is a code owner

@wxyucs wxyucs Awaiting requested review from wxyucs wxyucs is a code owner

Assignees

@LHT129 LHT129

Labels
kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LHT129 @jiaweizone @inabao