Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Signer trait for RevmMiddleware #804

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Conversation

Autoparallel
Copy link
Collaborator

Give an overview of the tasks completed
Implements the Signer trait for the RevmMiddleware struct.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (a6744b8) 56.48% compared to head (d6d8eb3) 56.04%.
Report is 7 commits behind head on main.

Files Patch % Lines
arbiter-core/src/middleware/mod.rs 0.00% 60 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #804      +/-   ##
==========================================
- Coverage   56.48%   56.04%   -0.45%     
==========================================
  Files          38       38              
  Lines        7637     7697      +60     
==========================================
  Hits         4314     4314              
- Misses       3323     3383      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems simple enough to me!

@0xJepsen 0xJepsen merged commit bf3e93b into main Jan 23, 2024
11 checks passed
@0xJepsen 0xJepsen deleted the arbiter-core/impl-signer branch January 23, 2024 21:35
@github-actions github-actions bot mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants