WP_Model::count() minor refactor

anthonybudd · Jun 1, 2017 · 15d25b6 · 15d25b6
1 parent ed2cb71
commit 15d25b6
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/readme.md b/readme.md
@@ -463,7 +463,7 @@ Product::single(); // Returns the current model if on a single page or in the lo
 
 Product::exists(15); // Returns (bool) true or false
 
-Product::count(); // Efficient way to get the number of models (Don't use count(WP_Model::all()))
+Product::count($postStatus = 'publish'); // Efficient way to get the number of models (Don't use count(WP_Model::all()))
 
 $product->get($attribute, $default) // Get attribute from the model
 

diff --git a/src/WP_Model.php b/src/WP_Model.php
@@ -582,10 +582,10 @@ public static function exists($ID, $postTypeSafe = TRUE)
 	 *
 	 * @return int
 	 */
-	public static function count()
+	public static function count($postStatus = 'publish')
 	{
 		$count = wp_count_posts(Self::getPostType());
-		return !is_null($count)? intval($count->publish) : 0;
+		return !is_null($count)? (isset($count->$postStatus)? intval($count->$postStatus) : 0) : 0;
 	}
 
 	/**

diff --git a/test/test.php b/test/test.php
@@ -421,6 +421,14 @@ function test(){
 			if(! ( is_int(Product::count())) ){
 				error(__LINE__ .' count()');
 			}
+
+			if(! ( is_int(Product::count('publish'))) ){
+				error(__LINE__ .' count()');
+			}
+
+			if(! ( Product::count('draft') == 0) ){
+				error(__LINE__ .' count()');
+			}
 
 		// ---- post()
 			$product = Product::insert([