Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version, fix dependencies and add gcc10 patch #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gardar
Copy link

@gardar gardar commented Jan 31, 2021

  • Bump version of firmware-mod-kit, there hasn't been a release for a long time but the master branch has had some activity.
  • Replaced the python-magic2 dependency with the python3 equivalent.
  • Added a patch for gcc10

@kpcyrd
Copy link
Contributor

kpcyrd commented Jan 31, 2021

This renames the package, you're welcome to create and maintain firmware-mod-kit-git in the AUR yourself. Also note that using git+git://github.com is insecure, can lead to rce and should be replaced with git+https://github.com.

@gardar
Copy link
Author

gardar commented Jan 31, 2021

Ah right, I renamed since I thought it would be needed to comply with the rules of aur, is there any way to keep the name while still grabbing the code from git? Perhaps by pinning it to a certain commit rather than following the branch.

The latest released version of firmware-mod-kit is way outdated and doesn't build unless we'd apply the changes from master through a patch or something like that.

@kpcyrd
Copy link
Contributor

kpcyrd commented Feb 1, 2021

Please signup at the aur to create the package yourself, this is more efficient than asking somebody else to maintain a package for you. :)

That the latest version is broken is unfortunate, but instead of pulling directly from the git repository you'd need to backport the individual patches to the last stable release to fix the compile issues. This can be quite cumbersome, so I'd recommend to urge upstream to cut a new release instead.

@gardar
Copy link
Author

gardar commented Feb 2, 2021

I already maintain a few packages in aur so that's not the issue, I just wanted to contribute to this package as it's broken and has been for some time.
I submitted a request for a new release, let's see how it goes.
rampageX/firmware-mod-kit#174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants