Skip to content

Commit

Permalink
scsi_dh_alua: remove 'rel_port' from alua_dh_data structure
Browse files Browse the repository at this point in the history
The 'relative port' field is not used, and might get stale when
the port group changes. So remove the field altogether.

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
  • Loading branch information
hreinecke authored and martinkpetersen committed Feb 24, 2016
1 parent aa90f49 commit 7af3361
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions drivers/scsi/device_handler/scsi_dh_alua.c
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ struct alua_port_group {
struct alua_dh_data {
struct alua_port_group *pg;
int group_id;
int rel_port;
struct scsi_device *sdev;
activate_complete callback_fn;
void *callback_data;
Expand Down Expand Up @@ -325,12 +324,10 @@ static int alua_check_vpd(struct scsi_device *sdev, struct alua_dh_data *h,
return SCSI_DH_NOMEM;
return SCSI_DH_DEV_UNSUPP;
}
h->rel_port = rel_port;

sdev_printk(KERN_INFO, sdev,
"%s: device %s port group %x rel port %x\n",
ALUA_DH_NAME, h->pg->device_id_str,
h->group_id, h->rel_port);
h->group_id, rel_port);

return alua_rtpg(sdev, h->pg);
}
Expand Down Expand Up @@ -762,7 +759,6 @@ static int alua_bus_attach(struct scsi_device *sdev)
if (!h)
return -ENOMEM;
h->pg = NULL;
h->rel_port = -1;
h->sdev = sdev;

err = alua_initialize(sdev, h);
Expand Down

0 comments on commit 7af3361

Please sign in to comment.