Skip to content

Commit

Permalink
net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and …
Browse files Browse the repository at this point in the history
…DEV_STATS_ADD()

[ Upstream commit b8ec0dc ]

mac802154 devices update their dev->stats fields locklessly. Therefore
these counters should be updated atomically. Adopt SMP safe DEV_STATS_INC()
and DEV_STATS_ADD() to achieve this.

Signed-off-by: Yunshui Jiang <jiangyunshui@kylinos.cn>
Message-ID: <20240531080739.2608969-1-jiangyunshui@kylinos.cn>
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Yunshui Jiang authored and gregkh committed Jul 27, 2024
1 parent c48d9c1 commit e011feb
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions net/mac802154/tx.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ void ieee802154_xmit_worker(struct work_struct *work)
if (res)
goto err_tx;

dev->stats.tx_packets++;
dev->stats.tx_bytes += skb->len;
DEV_STATS_INC(dev, tx_packets);
DEV_STATS_ADD(dev, tx_bytes, skb->len);

ieee802154_xmit_complete(&local->hw, skb, false);

Expand Down Expand Up @@ -86,8 +86,8 @@ ieee802154_tx(struct ieee802154_local *local, struct sk_buff *skb)
goto err_tx;
}

dev->stats.tx_packets++;
dev->stats.tx_bytes += len;
DEV_STATS_INC(dev, tx_packets);
DEV_STATS_ADD(dev, tx_bytes, len);
} else {
local->tx_skb = skb;
queue_work(local->workqueue, &local->tx_work);
Expand Down

0 comments on commit e011feb

Please sign in to comment.