fix(vertex): avoid credentials refresh on every request #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-lerner
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
This LGTM and I had a coworker take a look to confirm as well. He pointed out that there may be a slight danger of tokens expiring mid-request. You can have some multi-minute requests if token counts are high enough, but I'm not sure exactly what the failure mode looks like if that happens. It also looks like the google auth lib gives a 3.75 min buffer, so I think this is fine.
Thanks for the quick fix!
|
thanks for the review! mid-request expiries is a good callout, that was my main concern as well, maybe we could perform our own expiry calculation with an even bigger skew? e.g. 10 mins as thats our default request timeout? |
Merged
stainless-bot
pushed a commit
that referenced
this pull request
Jul 8, 2024
stainless-bot
pushed a commit
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #564. There will still be a delay for the first request but then the credentials will be cached.
I'm fairly nervous with this change will result in failures for certain cases as I'm not familiar enough with the google credentials system. Maybe we should ensure we try auth failures?