Add partial AVX512 Linux support for dot product on 4-bit quantized values #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Performance Impact
I'm seeing around 10% speedup on the 4-bit quantized 7B model when running on my AMD 7950x.
Before:
After:
I was hoping for more, but some other stuff I tried like converting the
bytesFromNibbles
function to operate on two blocks at a time by using AVX512 were not successful.