Add AnyError overloads for init(_:) and init(attempt:) #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdiep
reviewed
Jun 14, 2017
| self = .failure(AnyError(error)) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Are these overloads necessary?
The changes below compile without this change. I'm not sure what this adds.
(Type inference PRs are some of the hardest to review! 😅)
There was a problem hiding this comment.
I've just added https://github.com/antitypical/Result/pull/236/files#diff-edf3d2a3570d3672e50cbe6ca3ede069R140 and without these overloads that does not compile! 😮
The test case / result are bit different from #233.
ikesyo
force-pushed
the
init-anyerror-overloads
branch
2 times, most recently
from
9a1d9be
to
65d2c2d
Compare
ikesyo
force-pushed
the
init-anyerror-overloads
branch
from
65d2c2d
to
7d60acd
Compare
mdiep
approved these changes
Jul 3, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to but slightly different from #233 (and smaller diff). I prefer to have separate signatures for each
initoverloads.