-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swift 4.1 #259
Conversation
I'm also not really sure why we still need the manual [edit] Answer: https://twitter.com/dgregor79/status/954476048015478784. |
Result/ResultProtocol.swift
Outdated
extension Result: Equatable where Value: Equatable, Error: Equatable { } | ||
#else | ||
extension Result where Value: Equatable, Error: Equatable { | ||
/// Returns `true` if `left` and `right` represent different cases, or if they represent the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the end of this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Anything I can do to help expedite this? Result is blocking our upgrade to 4.1 as all the Swift 4 changes in master are not released. |
The current release of Result works with Xcode 9.3 / Swift 4.1. How is this blocking you? |
I'm getting this error:
|
FYI I’m out of town for a few weeks so somebody else will need to pick this up from me. |
After pointing our Podfile at master the build succeeds. |
I pick this up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be good to go now (except for Travis's xcode9.3beta
).
Should we wait for an updated Travis image? |
Over at ReSwift, we added compiler conditions to ship quickly ( |
Travis has released the |
Just updated to use the |
👏🏼 |
I'm using the latest development snapshot from January 18th. This compiles! 🎉Last updated and tested with:
Xcode 9.3 beta 2
.TODO:
Xcode 9.3
Update build setting (it's still set to4.0
, because the toolchain didn't change the build setting)Other improvements?