Enable dart non nullable by default (NNBD) #3116

renancaraujo · 2021-03-11T17:09:08Z

This PR (tries) to make the dart runtime comply with the standards of its 2.12 version.

lingyv-li · 2021-03-12T23:49:04Z

@renancaraujo @canastro thanks for your contribution!

So I used a trick to cache the dart packages mapping (.packages file), so we don't need to run pub get for each test case to reduce the test execution time. Find the code around cacheDartPackages in BaseDartTest.java.

Since a later Dart version, there was one more file that needs to be cached .dart_tool/package_config.json, otherwise it will not have the dart version information . Here is the code I got to do that:
lingyv-li@d78f54e#diff-eaff4da8b01719d6eba9cba3629f8760482002ffe3bde96729b31181ce7b1f7d

runtime/Dart/lib/src/atn/src/atn.dart

runtime/Dart/lib/src/atn/src/atn_config_set.dart

runtime/Dart/lib/src/atn/src/atn_deserializer.dart

canastro · 2021-03-16T16:12:15Z

runtime/Dart/lib/src/dfa/src/dfa_serializer.dart

@@ -19,14 +19,14 @@ class DFASerializer {

  @override
  String toString() {
-    if (dfa.s0 == null) return null;
+    if (dfa.s0 == null) return 'null';


Copied this from a earlier PR that attempted to upgrade to null safety

runtime/Dart/lib/src/parser_rule_context.dart

runtime/Dart/lib/src/prediction_context.dart

runtime/Dart/lib/src/token.dart

runtime/Dart/lib/src/token_stream.dart

runtime/Dart/lib/src/tree/src/tree.dart

canastro · 2021-03-30T07:59:05Z

@ericvergnaud this PR is ready for review, please let us know if you can help out. Thanks

stefanschaller · 2021-04-09T11:38:56Z

@canastro @ericvergnaud @lingyv-li Any news? Would be great to see progress with this pr

ericvergnaud · 2021-04-12T10:09:47Z

@canastro @ericvergnaud @lingyv-li Any news? Would be great to see progress with this pr

Hi,
no comment, but the CI isn't green.
Maybe you need to rebase?

stefanschaller · 2021-04-20T14:12:50Z

Maybe you need to rebase?

@canastro
Some steps of the pipeline still seems to fail.

canastro · 2021-04-20T14:25:10Z

hey @stefanschaller and @ericvergnaud missed that last notification. I'll look into it

renancaraujo · 2021-04-20T16:24:58Z

Since master is unstable, we got some red builds here as well.

ericvergnaud · 2021-05-06T13:23:21Z

The dart CI has moved from travis to circle-ci so you would need to rebase and get a green build before a merge can be envisaged

stefanschaller · 2021-05-06T14:44:12Z

The dart CI has moved from travis to circle-ci so you would need to rebase and get a green build before a merge can be envisaged

@ericvergnaud
The go-runtime step of the continuous-integration/appveyor/pr will fail for sure because there seems to be an issue in the master branch.
But this issue has nothing to do with this branch, correct? So what do you propose?

All pipeline steps that are related to the dart project, the feedback from the reviewers and contributors and everything is properly working / is done. What should we do? I mean, it's not the best idea that a go noob try to fix the appveyor pipeline for go, right?

ericvergnaud · 2021-05-06T14:55:02Z

The dart CI has moved from travis to circle-ci so you would need to rebase and get a green build before a merge can be envisaged

@ericvergnaud
The go-runtime step of the continuous-integration/appveyor/pr will fail for sure because there seems to be an issue in the master branch.
But this issue has nothing to do with this branch, correct? So what do you propose?

All pipeline steps that are related to the dart project, the feedback from the reviewers and contributors and everything is properly working / is done. What should we do? I mean, it's not the best idea that a go noob try to fix the appveyor pipeline for go, right?

I'm asking that you reenable circle-ci such that we can check if the dart target works fine on both Linux and Windows.
Some other guys are taking care of the go target.

stefanschaller · 2021-05-06T15:04:03Z

The dart CI has moved from travis to circle-ci so you would need to rebase and get a green build before a merge can be envisaged

@ericvergnaud
The go-runtime step of the continuous-integration/appveyor/pr will fail for sure because there seems to be an issue in the master branch.
But this issue has nothing to do with this branch, correct? So what do you propose?
All pipeline steps that are related to the dart project, the feedback from the reviewers and contributors and everything is properly working / is done. What should we do? I mean, it's not the best idea that a go noob try to fix the appveyor pipeline for go, right?

I'm asking that you reenable circle-ci such that we can check if the dart target works fine on both Linux and Windows.
Some other guys are taking care of the go target.

How to enable the pipeline that you are talking about? Is there a README, tutorial or something like that?

canastro · 2021-05-06T15:14:58Z

Not quite sure if this is it, but I added dart here: c201905

ericvergnaud · 2021-05-06T15:27:50Z

The dart CI has moved from travis to circle-ci so you would need to rebase and get a green build before a merge can be envisaged

@ericvergnaud
The go-runtime step of the continuous-integration/appveyor/pr will fail for sure because there seems to be an issue in the master branch.
But this issue has nothing to do with this branch, correct? So what do you propose?
All pipeline steps that are related to the dart project, the feedback from the reviewers and contributors and everything is properly working / is done. What should we do? I mean, it's not the best idea that a go noob try to fix the appveyor pipeline for go, right?

I'm asking that you reenable circle-ci such that we can check if the dart target works fine on both Linux and Windows.
Some other guys are taking care of the go target.

How to enable the pipeline that you are talking about? Is there a README, tutorial or something like that?

You might need to rebase
I see the go PRs get built but not this one.

canastro · 2021-05-06T15:38:06Z

@ericvergnaud I just re-checked to be sure, its rebased

parrt · 2021-05-06T16:14:54Z

Looks like DART is green and @lingyv-li appears to approve. Merging. thanks guys!

jnhyatt · 2021-05-06T16:51:34Z

What ANTLR version will this make it into?

parrt · 2021-05-06T16:53:03Z

We can shoot for a version in June, right @ericvergnaud ?

ericvergnaud · 2021-05-06T17:02:54Z

Yes all green here Envoyé de mon iPhone

…

Le 6 mai 2021 à 18:53, Terence Parr ***@***.***> a écrit : We can shoot for a version in June, right @ericvergnaud ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

ericvergnaud · 2021-05-28T10:06:09Z

Hi,

looks like the merge broke the master build?
@lingyv-li @canastro would you mind having a look?

canastro · 2021-05-28T10:17:28Z

@ericvergnaud in circleci? can you point me a link to the broken build? the only thing I found seemed to be green: https://app.circleci.com/pipelines/github/antlr/antlr4?branch=master

ericvergnaud · 2021-05-28T11:57:24Z

No it's broken in AppVeyor:
https://ci.appveyor.com/project/parrt/antlr4/build/job/f6d03ietj1ebwtu6

canastro · 2021-05-28T12:13:57Z

@ericvergnaud that link is pointing to a build of a PR that is still open: #3191

lingyv-li · 2021-05-28T12:49:20Z

+1 I believe that PR introduced the issue

canastro · 2021-10-11T10:14:31Z

@lingyv-li can we have a release with this to pub.dev?

lingyv-li · 2021-10-11T10:25:01Z

I could only make a prerelease, since the version needs to match the antlr version.
Would you be able to use the it as git dependency source?

canastro · 2021-10-11T10:27:04Z

Yup, going with that for now 👍🏽

jnhyatt · 2021-10-11T16:59:20Z

What's the schedule for a 4.9.3 release?

parrt · 2021-10-11T17:02:31Z

@ericvergnaud Maybe we should try for a release this Friday?

ericvergnaud · 2021-10-11T21:33:56Z

Yes I’m available Envoyé de mon iPhone

…

Le 11 oct. 2021 à 19:02, Terence Parr ***@***.***> a écrit : @ericvergnaud Maybe we should try for a release this Friday? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

parrt · 2021-10-11T21:36:34Z

I decided to start working towards the process now... If you could find things we need to merge or any other cleanup it would be great. then this week when everything looks stable, I can cut the release when I find time.

thanks again to everyone for all of your hard work!

canastro · 2021-10-14T20:44:05Z

@lingyv-li can you make a pre-release of the dart runtime to pub.dev?
I'm having some issues with installing from git in our pipeline (I've already tried to fix it by adding a ssh private key, but no luck).

lingyv-li · 2021-10-14T22:32:52Z

Sure, 4.9.3-dev.1 was released using 23f93e0.

renancaraujo changed the title ~~Enable dart non nullable by default (NNBD)~~ [WIP] Enable dart non nullable by default (NNBD) Mar 11, 2021

renancaraujo force-pushed the nnbd branch from aeb8410 to 8cd7f91 Compare March 12, 2021 14:25

renancaraujo mentioned this pull request Mar 12, 2021

[dart] Add support to dart's sound null safety #3114

Closed

canastro force-pushed the nnbd branch from 3d6f006 to 7857faf Compare March 12, 2021 23:20