Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# and Go runtime tests fixes on non-Windows OS #3386

Merged
merged 3 commits into from
Dec 6, 2021

Conversation

KvanTTT
Copy link
Member

@KvanTTT KvanTTT commented Dec 3, 2021

No description provided.

@KvanTTT
Copy link
Member Author

KvanTTT commented Dec 3, 2021

@ericvergnaud it seems like circleci builds now work for my account.

@KvanTTT KvanTTT force-pushed the csharp-go-runtime-tests-fixes branch 2 times, most recently from 89cebf8 to 4413122 Compare December 3, 2021 18:40
@KvanTTT KvanTTT force-pushed the csharp-go-runtime-tests-fixes branch from 4413122 to 5a23e37 Compare December 3, 2021 19:03
@KvanTTT KvanTTT marked this pull request as ready for review December 3, 2021 21:20
@KvanTTT
Copy link
Member Author

KvanTTT commented Dec 6, 2021

@ericvergnaud or @parrt please merge, it fixes the rest problems with tests.

@parrt
Copy link
Member

parrt commented Dec 6, 2021

Somehow I just got maven to work and install locally. All Java and C# tests pass on my mac. Are we sure these changes are needed? @ericvergnaud ?

@KvanTTT
Copy link
Member Author

KvanTTT commented Dec 6, 2021

Yes, maybe something wrong with your configuration or it only affects Linux, because it is reproducible on the current master: https://app.circleci.com/pipelines/github/antlr/antlr4 Those errors after that runtime tests optimization: #3365 (Linux status was not being displayed there because of some problem on CircleCI and my side, that's why I didn't notice them in time. But the problem was eventually resolved).

Also, I didn't mention Java, but Go

@parrt
Copy link
Member

parrt commented Dec 6, 2021

ok. let me look at these changes.

I am updating versions of all of the maven plug-ins in the poms. Is that a good idea? I'm working on another PR to get a reliable build.

@KvanTTT
Copy link
Member Author

KvanTTT commented Dec 6, 2021

I am updating versions of all of the maven plug-ins in the poms. Is that a good idea?

If everything works fine then why not. I have no objection.

@parrt
Copy link
Member

parrt commented Dec 6, 2021

all of the tests are passing so I will pull that in and see if I can build :)

@parrt parrt merged commit 3801358 into antlr:master Dec 6, 2021
@KvanTTT KvanTTT deleted the csharp-go-runtime-tests-fixes branch December 6, 2021 23:33
@parrt
Copy link
Member

parrt commented Dec 6, 2021

@KvanTTT C# doesn't test locally for me:

ANTLR installation corrupted; cannot find ANTLR messages format file org/antlr/v4/tool/templates/messages/formats/antlr.stg
ANTLR installation corrupted; cannot find ANTLR messages format file org/antlr/v4/tool/templates/messages/formats/antlr.stg

java.lang.Error: ANTLR ErrorManager panic

	at org.antlr.v4.tool.ErrorManager.panic(ErrorManager.java:303)
	at org.antlr.v4.tool.ErrorManager.setFormat(ErrorManager.java:229)
	at org.antlr.v4.Tool.<init>(Tool.java:200)
	at org.antlr.v4.test.runtime.BaseRuntimeTest.antlrOnString(BaseRuntimeTest.java:307)
	at org.antlr.v4.test.runtime.BaseRuntimeTest.antlrOnString(BaseRuntimeTest.java:276)
	at org.antlr.v4.test.runtime.csharp.BaseCSharpTest.rawGenerateRecognizer(BaseCSharpTest.java:123)
	at org.antlr.v4.test.runtime.csharp.BaseCSharpTest.rawGenerateRecognizer(BaseCSharpTest.java:111)
	at org.antlr.v4.test.runtime.csharp.BaseCSharpTest.execParser(BaseCSharpTest.java:90)
	at org.antlr.v4.test.runtime.BaseRuntimeTest.testParser(BaseRuntimeTest.java:220)
	at org.antlr.v4.test.runtime.BaseRuntimeTest.testOne(BaseRuntimeTest.java:182)
	at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:61)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
	at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:235)
	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)

that was in intellij. I'm rerunning using maven...

@KvanTTT
Copy link
Member Author

KvanTTT commented Dec 7, 2021

Not sure it's related to C#. Do other runtime tests work? Do you have installed dotnet? https://dotnet.microsoft.com/download

@parrt
Copy link
Member

parrt commented Dec 7, 2021

All is well. mvn works from the commandline.

@KvanTTT
Copy link
Member Author

KvanTTT commented Dec 7, 2021

CircleCi says that c# is OK in master: https://app.circleci.com/pipelines/github/antlr/antlr4/705/workflows/aa5f52e2-b8c0-41e5-8bc2-e96e46fc8a78 maybe it's invalid cache in Idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants