-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C# and Go runtime tests fixes on non-Windows OS #3386
Conversation
@ericvergnaud it seems like circleci builds now work for my account. |
89cebf8
to
4413122
Compare
Correct support of symbolic links
4413122
to
5a23e37
Compare
@ericvergnaud or @parrt please merge, it fixes the rest problems with tests. |
Somehow I just got maven to work and install locally. All Java and C# tests pass on my mac. Are we sure these changes are needed? @ericvergnaud ? |
Yes, maybe something wrong with your configuration or it only affects Linux, because it is reproducible on the current master: https://app.circleci.com/pipelines/github/antlr/antlr4 Those errors after that runtime tests optimization: #3365 (Linux status was not being displayed there because of some problem on CircleCI and my side, that's why I didn't notice them in time. But the problem was eventually resolved). Also, I didn't mention Java, but Go |
ok. let me look at these changes. I am updating versions of all of the maven plug-ins in the poms. Is that a good idea? I'm working on another PR to get a reliable build. |
If everything works fine then why not. I have no objection. |
all of the tests are passing so I will pull that in and see if I can build :) |
@KvanTTT C# doesn't test locally for me:
that was in intellij. I'm rerunning using maven... |
Not sure it's related to C#. Do other runtime tests work? Do you have installed dotnet? https://dotnet.microsoft.com/download |
All is well. mvn works from the commandline. |
CircleCi says that c# is OK in master: https://app.circleci.com/pipelines/github/antlr/antlr4/705/workflows/aa5f52e2-b8c0-41e5-8bc2-e96e46fc8a78 maybe it's invalid cache in Idea. |
No description provided.