Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime tests fixes (C++, Python, PHP, C#) #3725

Merged
merged 8 commits into from
Jun 5, 2022

Conversation

KvanTTT
Copy link
Member

@KvanTTT KvanTTT commented May 27, 2022

  • Set up C++ runtime tests on Windows
  • Add scripts for testing C++ on Windows
  • Fix python and php tests running from IDE

Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
@KvanTTT KvanTTT force-pushed the runtime-tests-fixes branch 2 times, most recently from 830b10f to e69088b Compare May 27, 2022 13:54
…nfrastructure

Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
@KvanTTT KvanTTT force-pushed the runtime-tests-fixes branch 2 times, most recently from cdbc224 to ef439c3 Compare May 27, 2022 14:18
@KvanTTT
Copy link
Member Author

KvanTTT commented May 27, 2022

Unfortunately I can't install msbuild on Windows using chocolatey because of denied access

C:\ProgramData\chocolatey\bin\cinst.exe visualstudio2022-workload-vctools -y

@parrt @ericvergnaud is it possible to install free Visual Studio Community 2022 or execute abovementioned command on self-hosted Windows machine?

@parrt
Copy link
Member

parrt commented May 28, 2022

@parrt @ericvergnaud is it possible to install free Visual Studio Community 2022 or execute abovementioned command on self-hosted Windows machine?

is ok with me if machine has disk space.

@KvanTTT
Copy link
Member Author

KvanTTT commented May 28, 2022

But I can't do it since I don't have access to the machine and it's self-hosted :)

@parrt
Copy link
Member

parrt commented May 28, 2022

Yep, waiting to hear from @ericvergnaud :)

Drop old version of Visual Studio C++ (2013, 2015, 2017), fixes antlr#3723

Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
…g ANTLR runtime (at least much less size of binary)
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Since it looks like MSBuild installing requires admin privileges
@KvanTTT
Copy link
Member Author

KvanTTT commented Jun 5, 2022

I temporary disabled C++ tests on Windows. @parrt I suggest merging since the request fixes Windows C++ projects (runtime and demo), the tests can be enabled later. Also, please don't squash my commits because I always put them in order, every commit fixes a problem (use rebase or merge).

@parrt
Copy link
Member

parrt commented Jun 5, 2022

Looks like excellent work, @KvanTTT thanks!

@parrt
Copy link
Member

parrt commented Jun 5, 2022

It looks like some of the commits did not have DCO but I forced it

@ericvergnaud
Copy link
Contributor

Have you tried actions/setup-dotnet@v1 ?
I believe it contains MSBuild

@KvanTTT
Copy link
Member Author

KvanTTT commented Jul 7, 2022

No, but I almost sure it won't help since dotnet doesn't use msbuild.

@ericvergnaud
Copy link
Contributor

ericvergnaud commented Jul 7, 2022 via email

@KvanTTT
Copy link
Member Author

KvanTTT commented Jul 8, 2022

Ok, even so, such msbuild doesn't have required c++ libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants