-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime tests fixes (C++, Python, PHP, C#) #3725
Conversation
KvanTTT
commented
May 27, 2022
- Set up C++ runtime tests on Windows
- Add scripts for testing C++ on Windows
- Fix python and php tests running from IDE
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
830b10f
to
e69088b
Compare
…nfrastructure Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
cdbc224
to
ef439c3
Compare
Unfortunately I can't install msbuild on Windows using chocolatey because of denied access
@parrt @ericvergnaud is it possible to install free Visual Studio Community 2022 or execute abovementioned command on self-hosted Windows machine? |
is ok with me if machine has disk space. |
But I can't do it since I don't have access to the machine and it's self-hosted :) |
Yep, waiting to hear from @ericvergnaud :) |
db0e7ce
to
daf37f6
Compare
Drop old version of Visual Studio C++ (2013, 2015, 2017), fixes antlr#3723 Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Remove outdated projects (2013, 2015)
…g ANTLR runtime (at least much less size of binary)
Signed-off-by: Ivan Kochurkin <kvanttt@gmail.com>
Since it looks like MSBuild installing requires admin privileges
daf37f6
to
7fc0d4d
Compare
I temporary disabled C++ tests on Windows. @parrt I suggest merging since the request fixes Windows C++ projects (runtime and demo), the tests can be enabled later. Also, please don't squash my commits because I always put them in order, every commit fixes a problem (use rebase or merge). |
Looks like excellent work, @KvanTTT thanks! |
It looks like some of the commits did not have DCO but I forced it |
Have you tried actions/setup-dotnet@v1 ? |
No, but I almost sure it won't help since dotnet doesn't use msbuild. |
This suggests the opposite:
https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-msbuild <https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-msbuild>
… Le 7 juil. 2022 à 18:48, Ivan Kochurkin ***@***.***> a écrit :
No, but I almost sure it won't help since dotnet doesn't require msbuild.
—
Reply to this email directly, view it on GitHub <#3725 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZNQJAU37WWILUNA5HAQ33VS4C6PANCNFSM5XD7DD7Q>.
You are receiving this because you were mentioned.
|
Ok, even so, such msbuild doesn't have required c++ libraries. |