Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package.swift: provide an option to link against ANTLR 4 statically #3906

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Package.swift: provide an option to link against ANTLR 4 statically #3906

merged 1 commit into from
Oct 10, 2022

Conversation

edigaryev
Copy link
Contributor

Problem: currently there's no way to link against ANTLR 4 statically from Swift, which is a deal-breaker if you want to ship a single binary. See cirruslabs/tart#230 for example.

Solution: normally, the type: .dynamic should be omitted from library product specification, but changing this now might break things for Swift users. Solve this by introducing a separate Swift PM product Antlr4Static that explicitly specifies type: .static.

Signed-off-by: Nikolay Edigaryev <edigaryev@gmail.com>
@edigaryev
Copy link
Contributor Author

@parrt mind taking a look at this?

We need this to be able to use ANTLR 4 in Tart, see cirruslabs/tart#230.

Thanks!

@parrt
Copy link
Member

parrt commented Sep 30, 2022

ok, though we normally do PRs on dev. can you rebase on that?

@parrt parrt added this to the 4.11.2 milestone Sep 30, 2022
@edigaryev edigaryev changed the base branch from master to dev October 1, 2022 20:13
@edigaryev
Copy link
Contributor Author

ok, though we normally do PRs on dev. can you rebase on that?

Done 👌

@edigaryev
Copy link
Contributor Author

@parrt sorry to nudge you, but mind taking a look at this once more?

@parrt parrt merged commit 2703a85 into antlr:dev Oct 10, 2022
@parrt
Copy link
Member

parrt commented Oct 10, 2022

Thanks for the nudge. I get way too much email from way too many open source packages to maintain ha ha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants