Issue #4185: Too many artifacts fail to upload #4186
Conversation
|
Is this ready or...maybe not? |
Github action for upload was upgraded to v3 recently and the release is unstable causing too many uploads to fail. Downgrading back to previous version hasn't made significant improvement either. Since the artifacts aren't exactly used by any chained job, failures for uploading the artifact can be ignored. The artifacts are used mostly for the purpose for debugging and so if needed the user can trigger specific build again to get the artifact. Signed-off-by: HS <hs@apotell.com>
|
I did downgrade the version but that hasn't exactly had the improvement I was hoping for. So, I have marked the specific action to ignore the failure. The artifacts aren't used in the build process itself. They are mostly for the purpose of debugging build issues and so if any artifact failed to upload and the user needs it, he/she can trigger the build again. I will keep an eye on the specific reported issue on the actions host repository for any progress and introduce the necessary fix here. In the meantime, it should prevent builds being marked as failed because of failure to upload the artifact. If all the checks pass successfully, it is ready to merge! |
|
The specific failure isn't related to the changes in this PR. |
|
Almost works! Now just C#...hmm... https://github.com/antlr/antlr4/actions/runs/4459126836/jobs/7831382670?pr=4186#step:24:3264 seems VM died. |
I think this is referring to the java VM and not the build VM. Looks like the tests failed for some reason and that caused the VM to abort unpredictably. I don't have permissions to kick off this specific build again to see if this is reproducible. You could do that. Also, it would help to confirm if the tests are passing locally or not since it seems like the tests are actually failing for the csharp target. |
|
kicked off that one again...c# works on others like ubuntu so...must be the mac platform? |
|
Hmm... |
|
@parrt This branch is ready for merge. Anything holding back? |
|
Thanks for the help and sorry for the delay! |
Github action for upload was upgraded to v3 recently and the release is unstable causing too many uploads to fail. Downgrading back to previous version hasn't made significant improvement either. Since the artifacts aren't exactly used by any chained job, failures for uploading the artifact can be ignored. The artifacts are used mostly for the purpose for debugging and so if needed the user can trigger specific build again to get the artifact. Signed-off-by: HS <hs@apotell.com> Signed-off-by: Jim.Idle <jimi@idle.ws>
Issue #4185: Too many artifacts fail to upload
Github action for upload was upgraded to v3 recently and the release is unstable causing too many uploads to fail. Reverting that change to go back to using v2.
Unfortunately, this change also downgrades use of Node.js to 12 which is deprecated, generating too many warnings in build output. Favoring warnings over failed builds.