Skip to content

Commit

Permalink
fix(pwa): remove redirect fallback (#830)
Browse files Browse the repository at this point in the history
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced caching capabilities by including `json` and `woff2` file
types in the service worker's precaching strategy.
- Introduced a new property to manage navigation requests, improving
routing control.

- **Improvements**
- Development server now runs on port 4000, allowing for more controlled
access during development.

- **Bug Fixes**
- Streamlined acceptance test for the Game Lobby Options Hub by removing
unnecessary user action, improving test efficiency.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
antoinezanardi committed Sep 8, 2024
1 parent 7b715fd commit 69c2c21
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 50 deletions.
5 changes: 3 additions & 2 deletions nuxt.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,11 @@ export default defineNuxtConfig({
periodicSyncForUpdates: 86400,
},
workbox: {
globPatterns: ["**/*.{js,css,html,png,svg,ico}"],
globPatterns: ["**/*.{js,css,html,png,svg,ico,json,woff2}"],
navigateFallbackDenylist: [/^.*$/u],
},
injectManifest: {
globPatterns: ["**/*.{js,css,html,png,svg,ico}"],
globPatterns: ["**/*.{js,css,html,png,svg,ico,json,woff2}"],
},
manifest: {
name: process.env.NUXT_SITE_NAME,
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"start:prod": "node .output/server/index.mjs",
"prepare": "is-ci || husky",
"build": "nuxt build",
"dev": "nuxt dev --dotenv env/.env.development",
"dev": "nuxt dev --dotenv env/.env.development --port 4000",
"generate": "nuxt generate",
"preview": "npm run build && nuxt preview --dotenv env/.env.production",
"postinstall": "! ls -log -u node_modules/.bin/nuxt || nuxt prepare",
Expand Down
46 changes: 0 additions & 46 deletions public/favicons/site.webmanifest

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ Feature: ⚙️ Game Lobby Options Hub
And the user disables the sheriff in game options

When the user reloads the page
And the user clicks on the link with name "Play"
And the user clicks on the game options button in the lobby
Then the heading with name "Game options" should be visible
And the exact text "The game will not have a Sheriff." should be visible
Expand Down

0 comments on commit 69c2c21

Please sign in to comment.