Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misc-pages): responsive for canceled game and not found game pages #888

Merged
merged 2 commits into from
Sep 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions app/components/pages/game/GameCanceled/GameCanceled.vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<div
id="game-canceled"
class="flex flex-col items-center justify-center"
class="flex flex-col gap-2 items-center justify-center"
>
<h1
id="game-canceled-text"
Expand All @@ -17,12 +17,12 @@
</span>
</h1>

<div>
<PrimeVueDivider class="mb-4"/>
<PrimeVueDivider class="!w-2/3"/>
antoinezanardi marked this conversation as resolved.
Show resolved Hide resolved

<CreateAnotherGameButton/>
<div class="flex flex-col gap-2 md:flex-row">
<CreateAnotherGameButton class="md:w-auto w-full"/>

<BackToHomeButton/>
<BackToHomeButton class="md:w-auto w-full"/>
</div>
</div>
</template>
Expand Down
12 changes: 6 additions & 6 deletions app/components/pages/game/GameNotFound/GameNotFound.vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<div
id="game-not-found"
class="flex flex-col items-center justify-center"
class="flex flex-col gap-2 items-center justify-center"
>
<h1
id="game-not-found-text"
Expand All @@ -12,17 +12,17 @@
icon="fa-regular fa-question-circle"
/>

<span>
<span class="text-center">
{{ $t("components.GameNotFound.gameNotFound") }}
</span>
</h1>

<div>
<PrimeVueDivider class="mb-4"/>
<PrimeVueDivider class="!w-2/3"/>

<CreateAnotherGameButton class="me-2"/>
<div class="flex flex-col gap-2 md:flex-row">
<CreateAnotherGameButton class="md:w-auto w-full"/>

<BackToHomeButton/>
<BackToHomeButton class="md:w-auto w-full"/>
</div>
</div>
</template>
Expand Down
4 changes: 2 additions & 2 deletions app/error.vue
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
>
<h1
id="error-title"
class="!text-5xl"
class="!text-5xl text-center"
>
{{ errorTitle }}
</h1>
Expand All @@ -20,7 +20,7 @@

<h3
id="error-description"
class="!text-2xl"
class="md:!text-2xl text-center text-xl"
>
{{ errorDescription }}
</h3>
Expand Down
Binary file modified tests/acceptance/screenshots/darwin/Game canceled.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/acceptance/screenshots/darwin/Game not found.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/acceptance/screenshots/linux/Game canceled.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/acceptance/screenshots/linux/Game not found.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading