Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(derive): BatchStream Past batch handling #876

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Dec 22, 2024

Overview

Fixes the handling of the BatchValidity::Past condition. It's currently throwing a temporary Eof, but the desired behavior is to continue reading old batches until all past batches have been read, validated, and discarded due to their timestamp.

@clabby clabby added A-derive Area: kona-derive crate K-fix Kind: fix labels Dec 22, 2024
@clabby clabby self-assigned this Dec 22, 2024
@clabby clabby requested a review from refcell as a code owner December 22, 2024 21:49
@clabby clabby linked an issue Dec 22, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.5%. Comparing base (7a40d87) to head (80e304e).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/derive/src/stages/batch/batch_stream.rs 0.0% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Inphi
Copy link

Inphi commented Dec 23, 2024

is/will there be an action test covering this case?

@clabby
Copy link
Collaborator Author

clabby commented Dec 24, 2024

is/will there be an action test covering this case?

Not yet, but set a reminder to get one in once I'm back to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate K-fix Kind: fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate incorrect result in vm-runner on sepolia
2 participants