Make prefix regex non-greedy #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to deal with major version numbers > 9. Without this patch, a version like v42.1.0 would be parsed as 2.1.0, stripping a prefix of v4
rgriebl
force-pushed
the
fix_greedy_prefix_regex
branch
from
720ab8f
to
b879f21
Compare
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
=======================================
Coverage 85.98% 85.98%
=======================================
Files 7 7
Lines 264 264
=======================================
Hits 227 227
Misses 24 24
Partials 13 13 |
|
Amazing 👏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to deal with major version numbers > 9.
Without this patch, a version like v42.1.0 would be parsed as 2.1.0, stripping a prefix of v4