-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Extend terraform_validate
--retry-once-with-cleanup
errors list
#566
Conversation
hooks/terraform_validate.sh
Outdated
@@ -100,6 +101,7 @@ function per_dir_hook_unique_part { | |||
|
|||
case $key in | |||
--retry-once-with-cleanup) | |||
# shellcheck disable=SC2086 # It's just works. Maybe will be fixed later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# shellcheck disable=SC2086 # It's just works. Maybe will be fixed later | |
# shellcheck disable=SC2086 # It just works. Maybe will be fixed later |
JFYI: it should work the same way if the var is wrapped into double quotes (if [ "$retry_once_with_cleanup" ]; then
), though as suggested by shellcheck
is a way much more secure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, okay. Let's then add quotes, and hope that it will not break anything (once I'll wrote tests, but not today)
--retry-once-with-cleanup
terraform_validate errors listterraform_validate
--retry-once-with-cleanup
errors list
## [1.83.2](v1.83.1...v1.83.2) (2023-09-04) ### Bug Fixes * Extend `terraform_validate` `--retry-once-with-cleanup` errors list ([#566](#566)) ([19188e5](19188e5))
This PR is included in version 1.83.2 🎉 |
Put an
x
into the box if that apply:Description of your changes
Fixes #561
How can we test changes
To reproduce:
Test fix:
.pre-commit-config.yaml
from
to
run