-
-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(non-linux): Bash environment variables in arguments not expanded + Add trace
log level
#645
Conversation
trace
log level
trace
log leveltrace
log level for the throne of debugging God
trace
log level for the throne of debugging Godtrace
log level
Kinda the same GNU vs POSIX implementation of |
Is there perhaps some other way to achieve what is going on there with the regex? What's the purpose of the |
This PR corrects the questionable regex and this also eliminates diff between Linux/non-Linux implementations as far as I understand.
https://github.com/antonbabenko/pre-commit-terraform#all-hooks-usage-of-environment-variables-in---args — |
Co-authored-by: George L. Yermulnik <yz@yz.kiev.ua>
## [1.88.2](v1.88.1...v1.88.2) (2024-03-13) ### Bug Fixes * **non-linux:** Bash environment variables in arguments not expanded + Add `trace` log level ([#645](#645)) ([a2a2990](a2a2990))
This PR is included in version 1.88.2 🎉 |
…+ Add `trace` log level (#645) --------- Co-authored-by: George L. Yermulnik <yz@yz.kiev.ua>
## [1.88.2](v1.88.1...v1.88.2) (2024-03-13) ### Bug Fixes * **non-linux:** Bash environment variables in arguments not expanded + Add `trace` log level ([#645](#645)) ([a2a2990](a2a2990))
## [1.88.2](antonbabenko/pre-commit-terraform@v1.88.1...v1.88.2) (2024-03-13) ### Bug Fixes * **non-linux:** Bash environment variables in arguments not expanded + Add `trace` log level ([#645](antonbabenko/pre-commit-terraform#645)) ([9324129](antonbabenko/pre-commit-terraform@9324129))
Put an
x
into the box if that apply:Description of your changes
?
is not supported in bash regex outside Linux.Add trace log level for very problematic cases (relates to Introduce log levels and move unneeded logs to
debug
log level #562)Fixes #638
How can we test changes
and run
pre-commit run -a
PCT_LOG=trace pre-commit run -a