-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Looks to be broken on latest Node.js (10.1.0) #7
Comments
@antongolub Do you happen to know what's breaking it? We certainly didn't intend to break any third-party modules with that change. If you can point me to the relevant code in this module, I would be happy to look at what we can do. Edit: Oh, I'm guessing this might be due to the some of the stricter checks. I see that you're just using prototype methods but not necessarily applying them to data matching our classes. (Our values are always null when empty but in your case it looks it's undefined.) |
I've used mixins and some part of OutgoingMessage constructor logic was skipped. And thank you for attention. |
<a name="1.4.1"></a> ## [1.4.1](v1.4.0...v1.4.1) (2018-05-17) ### Bug Fixes * **response:** initialize inner _headers map for node v10.1.0 compatibility ([cf19b6d](cf19b6d)), closes [#7](#7)
🎉 This issue has been resolved in version 1.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Should be related to the latest http module changes: nodejs/node#20250
The text was updated successfully, but these errors were encountered: