minor improve

antonmashko · Sep 14, 2023 · 828f9a8 · 828f9a8
1 parent 80d4c5a
commit 828f9a8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/external.go b/external.go
@@ -15,11 +15,11 @@ type External interface {
 
 type emptyExt struct{}
 
-func (c *emptyExt) TagName() string {
+func (emptyExt) TagName() string {
 	return ""
 }
 
-func (c *emptyExt) Unmarshal(v interface{}) error { return nil }
+func (emptyExt) Unmarshal(v interface{}) error { return nil }
 
 type externalConfig struct {
 	s    *structType
@@ -35,6 +35,9 @@ func newExternalConfig(ext External) *externalConfig {
 }
 
 func (c *externalConfig) Unmarshal(v interface{}) error {
+	if c.ext == (emptyExt{}) {
+		return nil
+	}
 	mp := make(map[string]interface{})
 	err := c.ext.Unmarshal(&mp)
 	if err != nil {

diff --git a/parser.go b/parser.go
@@ -27,7 +27,7 @@ type EnvConf struct {
 }
 
 func New() *EnvConf {
-	return NewWithExternal(&emptyExt{})
+	return NewWithExternal(emptyExt{})
 }
 
 func NewWithExternal(e External) *EnvConf {