Fixing empty string return and segfault on finish!

antony-jr · Jan 13, 2018 · e854b47 · e854b47
1 parent 21a57c3
commit e854b47
Showing 1 changed file with 31 additions and 0 deletions.
diff --git a/AIUpdaterBridge.cpp b/AIUpdaterBridge.cpp
@@ -820,6 +820,18 @@ void AIUpdaterBridge::doUpdate(void)
     }
 
     if(stopUpdate) {
+        appImage.clear();
+        zsyncHeader.clear();
+        zsyncFileName.clear();
+        zsyncHeaderJson = QJsonObject(); // clean zsync header
+        zsyncURL.clear();
+        fileURL.clear();
+
+        if(zsyncFile != NULL){
+         free(zsyncFile);
+         zsyncFile = NULL;
+        }
+        github = stopUpdate = false;
         mutex.unlock();
         emit(stopped());
         return;
@@ -884,7 +896,26 @@ void AIUpdaterBridge::doUpdate(void)
             emit error(LocalFile, POST_INSTALLATION_FAILED);
             return;
         }
+
+        /*
+         * Clear everything -> This is really important!
+        */
+        zsyncHeader.clear();
+        zsyncFileName.clear();
+        zsyncHeaderJson = QJsonObject(); // clean zsync header
+        zsyncURL.clear();
+        fileURL.clear();
+
+        if(zsyncFile != NULL){
+         /*
+          * Do not free here!
+         */
+         zsyncFile = NULL;
+        }
+        github = stopUpdate = false;
+
         emit updateFinished(appImage, RemoteSHA1);  // Yeaa , Finally Finished Gracefully!
+        appImage.clear();
     }
     mutex.unlock();
     return;