Fix frontend crash in Summary page when data is missing #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Antrea runs in networkPolicyOnly mode, the nodeSubnets field is missing (omitted because empty) from AntreaAgentInfo resources. The frontend needs to handle this case gracefully. Fixes antrea-io#22 Signed-off-by: Antonin Bas <abas@vmware.com>
xliuxu
reviewed
Apr 28, 2023
|
|
||
| function refToString(ref: K8sRef): string { | ||
| function refToString(ref: K8sRef | undefined): string { |
There was a problem hiding this comment.
Suggested change
| function refToString(ref: K8sRef | undefined): string { | |
| function refToString(ref?: K8sRef): string { |
xliuxu
reviewed
Apr 28, 2023
| if (ref.namespace) return ref.namespace + '/' + ref.name; | ||
| return ref.name; | ||
| } | ||
|
|
||
| // returns status and last heartbeat time | ||
| function getConditionInfo(conditions: Condition[], name: string): [string, string] { | ||
| function getConditionInfo(conditions: Condition[] | undefined, name: string): [string, string] { |
There was a problem hiding this comment.
the 2 mean different things:
function getConditionInfo(conditions: Condition[] | undefined, name: string)
function getConditionInfo(conditions?: Condition[], name: string)
The second one is not valid because ?: indicates an optional parameter, and an optional parameter cannot come before a required parameter (name). Here conditions is not really an optional parameter, but a required parameter that can be undefined.
|
@xliuxu Thanks for the quick review. I'll merge as it is to fix the bug. If you have a better alternative, let me know. I was considering handling the |
antoninbas
added a commit
that referenced
this pull request
May 4, 2023
When Antrea runs in networkPolicyOnly mode, the nodeSubnets field is missing (omitted because empty) from AntreaAgentInfo resources. The frontend needs to handle this case gracefully. Fixes #22 Signed-off-by: Antonin Bas <abas@vmware.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Antrea runs in networkPolicyOnly mode, the nodeSubnets field is missing (omitted because empty) from AntreaAgentInfo resources. The frontend needs to handle this case gracefully.
Fixes #22