Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Antrea images (for Agent and Controller) available in ghcr.io #6454

Closed
antoninbas opened this issue Jun 17, 2024 · 3 comments · Fixed by #6834
Closed

Make Antrea images (for Agent and Controller) available in ghcr.io #6454

antoninbas opened this issue Jun 17, 2024 · 3 comments · Fixed by #6834
Assignees
@antoninbas
Labels
area/build-release Issues or PRs related to building and releasing priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
Antrea v2.3 release

Comments

@antoninbas
Copy link
Contributor

It would be good to have an alternative to DockerHub for images which are consumed directly by users, with the main ones being antrea/antrea-agent-ubuntu and antrea/antrea-controller-ubuntu. ghcr.io seems like a good candidate, and I could not find any information about possible rate-limiting for unauthenticated users pulling public packages, so I assume there is none. Even though the antrea namespace on DockerHub should be exempt from pull rate-limiting, in practice we have observed that users should still be authenticated (no official source for this, but this is what we have observed in CI).

This issue should probably be handled after #6453, as we need to simplify our build infrastructure first. At the moment, image manifests are pushed from a Github Action Workflow hosted in a separate private repository (see linked issue for details). Once everything has been moved to this repository, it will be easy to authenticate to ghcr.io from the Github Workflows to push images, as we can just use the built-in GITHUB_TOKEN.
@antoninbas antoninbas added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. area/build-release Issues or PRs related to building and releasing labels Jun 17, 2024
@rajnkamr
Copy link
Contributor

There isn't any hard pull rate currently for images pulled from ghrc.io, however It seems that push/pull is taking longer than expected from ghcr.io, although it could improve in future ! https://github.com/orgs/community/discussions/27080#discussioncomment-9122685

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 24, 2024
@rajnkamr rajnkamr removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 24, 2024
@antoninbas antoninbas self-assigned this Sep 24, 2024
@antoninbas
Copy link
Contributor Author

It seems that some Github API rate limits may apply when pulling from ghcr.io (for unauthenticated and authenticated users), but still it would be good to have an alternative to docker.io instead of depending on a single registry.

@antoninbas antoninbas added this to the Antrea v2.3 release milestone Oct 25, 2024
antoninbas added a commit to antoninbas/antrea that referenced this issue Nov 26, 2024
@antoninbas
Push Antrea Ubuntu-based images to ghcr.io
377900d 
The Github Container Registry (ghcr.io) is introduced as an alternative
to Docker Hub for users. There is no change to how images are pushed to
Docker Hub, but antrea/antrea-agent-ubuntu and
antrea/antrea-controller-ubuntu are now also available in ghcr.io, as
antrea-io/antrea-agent-ubuntu and antrea-io/antrea-controller-ubuntu
respectively.

We do not retroactively push previously-released images to
ghcr.io. Antrea v2.3 will be the first release also available in ghcr.io.

In the future, we may also push UBI-based images to ghcr.io.

Fixes antrea-io#6454

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas added a commit to antoninbas/antrea that referenced this issue Nov 26, 2024
@antoninbas
Push Antrea Ubuntu-based images to ghcr.io
95b2998 
The Github Container Registry (ghcr.io) is introduced as an alternative
to Docker Hub for users. There is no change to how images are pushed to
Docker Hub, but antrea/antrea-agent-ubuntu and
antrea/antrea-controller-ubuntu are now also available in ghcr.io, as
antrea-io/antrea-agent-ubuntu and antrea-io/antrea-controller-ubuntu
respectively.

We do not retroactively push previously-released images to
ghcr.io. Antrea v2.3 will be the first release also available in ghcr.io.

In the future, we may also push UBI-based images to ghcr.io.

Fixes antrea-io#6454

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
@antoninbas antoninbas mentioned this issue Nov 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antoninbas antoninbas

Labels
area/build-release Issues or PRs related to building and releasing priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
Antrea v2.3 release
Development

Successfully merging a pull request may close this issue.

Push Antrea Ubuntu-based images to ghcr.io antoninbas/antrea
2 participants
@antoninbas @rajnkamr