-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Add enhancement in the script Clean-AntreaNetwork.ps1 #2550
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2550 +/- ##
==========================================
+ Coverage 60.70% 60.74% +0.04%
==========================================
Files 286 286
Lines 23096 23096
==========================================
+ Hits 14020 14030 +10
+ Misses 7598 7591 -7
+ Partials 1478 1475 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
4326a7e
to
14ef49f
Compare
/skip-all |
/skip-ipv6-all |
14ef49f
to
53ff890
Compare
/test-ipv6-e2e |
/skip-all |
b40b59b
to
fa12d03
Compare
/skip-all |
hack/windows/Clean-AntreaNetwork.ps1
Outdated
stop-service ovsdb-server | ||
|
||
# $OVSInstallDir is where OVS is installed. It is the path argument when using Install-OVS.ps1. | ||
$OVSInstallDir="C:\openvswitch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to define these paths at the beginning of the file, so users can find them easier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, updated.
fa12d03
to
ec87492
Compare
/skip-ipv6-all |
/skip-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Remove Hyper-V binding on the network adapter which is used as OVS uplink, otherwise the adapter is not possible to recover IP address after HNSNetwork cleanup. Signed-off-by: wenyingd <wenyingd@vmware.com>
ec87492
to
b2e4a9f
Compare
/skip-all |
/skip-hw-offload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…#2550) Remove Hyper-V binding on the network adapter which is used as OVS uplink, otherwise the adapter is not possible to recover IP address after HNSNetwork cleanup. Signed-off-by: wenyingd <wenyingd@vmware.com>
[Windows] Add enhancement in the script Clean-AntreaNetwork.ps1
to ensure Windows IP address to come back.
Signed-off-by: wenyingd wenyingd@vmware.com