Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[traceflow] Validate source Pod for non-live-traffic Traceflow #2736

Merged
merged 1 commit into from
Oct 22, 2021
Merged

[traceflow] Validate source Pod for non-live-traffic Traceflow #2736

merged 1 commit into from
Oct 22, 2021

Conversation

gran-vmv
Copy link
Contributor

@gran-vmv gran-vmv commented Sep 9, 2021 •
edited
Loading

antrea-controller will update the status to "Failed" immediately if the source is an invalid Pod or hostNetwork Pod for a non-live-traffic Traceflow.

@gran-vmv gran-vmv self-assigned this Sep 9, 2021
@gran-vmv gran-vmv force-pushed the tf-host branch 2 times, most recently from 773bce0 to bd0454a Compare September 9, 2021 10:12
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2021 •
edited
Loading

Codecov Report

Merging #2736 (823b35a) into main (9f16b69) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2736      +/-   ##
==========================================
+ Coverage   61.62%   61.69%   +0.07%     
==========================================
  Files         283      283              
  Lines       23779    23792      +13     
==========================================
+ Hits        14653    14678      +25     
+ Misses       7543     7541       -2     
+ Partials     1583     1573      -10
Flag Coverage Δ
kind-e2e-tests 49.43% <100.00%> (+0.18%) ⬆️
unit-tests 40.63% <69.23%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/traceflow/controller.go 74.71% <100.00%> (-0.44%) ⬇️
pkg/agent/flowexporter/exporter/certificate.go 50.00% <0.00%> (-16.67%) ⬇️
pkg/apiserver/storage/ram/store.go 78.35% <0.00%> (-1.50%) ⬇️
pkg/agent/flowexporter/exporter/exporter.go 80.32% <0.00%> (-0.66%) ⬇️
pkg/agent/config/node_config.go 100.00% <0.00%> (ø)
pkg/agent/openflow/pipeline.go 78.40% <0.00%> (+0.42%) ⬆️
pkg/log/log_file.go 71.25% <0.00%> (+1.25%) ⬆️
pkg/controller/networkpolicy/store/addressgroup.go 86.79% <0.00%> (+3.77%) ⬆️
pkg/legacyclient/clientset/versioned/clientset.go 38.70% <0.00%> (+12.90%) ⬆️
... and 1 more

@gran-vmv
Copy link
Contributor Author

gran-vmv commented Sep 9, 2021

/test-all

@gran-vmv
Copy link
Contributor Author

gran-vmv commented Sep 9, 2021

/test-all

antoninbas
antoninbas reviewed Sep 9, 2021
View reviewed changes
pkg/controller/traceflow/controller.go Outdated Show resolved Hide resolved
pkg/controller/traceflow/controller.go Outdated Show resolved Hide resolved
pkg/controller/traceflow/controller.go Outdated Show resolved Hide resolved
pkg/controller/traceflow/controller.go Outdated Show resolved Hide resolved
pkg/controller/traceflow/controller.go Show resolved Hide resolved
test/e2e/traceflow_test.go Show resolved Hide resolved
jianjuns
jianjuns reviewed Sep 9, 2021
View reviewed changes
Copy link
Contributor

@jianjuns jianjuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the commit description:

antrea-controller will updated the status to "Failed" immediately if the source is invalid Pod or hostNetwork Pod on non-live-traffic Traceflow.

updated -> update

is an invalid Pod

on non-live-traffic Traceflow -> for a non-live-traffic Traceflow

@gran-vmv gran-vmv force-pushed the tf-host branch 2 times, most recently from b23e9f2 to fe36d73 Compare September 10, 2021 02:39
@gran-vmv
Copy link
Contributor Author

In the commit description:

antrea-controller will updated the status to "Failed" immediately if the source is invalid Pod or hostNetwork Pod on non-live-traffic Traceflow.

updated -> update

is an invalid Pod

on non-live-traffic Traceflow -> for a non-live-traffic Traceflow

Thanks. Fixed.

@gran-vmv gran-vmv force-pushed the tf-host branch 3 times, most recently from 7f35e9d to 6b51899 Compare September 10, 2021 06:19
@gran-vmv
Copy link
Contributor Author

/test-e2e
/test-ipv6-only-e2e
/test-ipv6-e2e

@gran-vmv
Copy link
Contributor Author

/test-all
/test-ipv6-all
/test-ipv6-only-all

@gran-vmv
Copy link
Contributor Author

/test-networkpolicy
/test-windows-networkpolicy

@gran-vmv
Copy link
Contributor Author

/test-windows-networkpolicy

@gran-vmv
Copy link
Contributor Author

/test-all
/test-ipv6-all
/test-ipv6-only-all

@gran-vmv
Copy link
Contributor Author

@antoninbas @jianjuns @edwardbadboy Any new comments or approval?

jianjuns
jianjuns previously approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@jianjuns jianjuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

antoninbas
antoninbas reviewed Oct 19, 2021
View reviewed changes
pkg/controller/traceflow/controller.go Outdated Show resolved Hide resolved
pkg/controller/traceflow/controller.go Outdated Show resolved Hide resolved
pkg/controller/traceflow/controller.go Outdated Show resolved Hide resolved
pkg/controller/traceflow/controller_test.go Outdated Show resolved Hide resolved
@gran-vmv
Copy link
Contributor Author

/test-all

@gran-vmv
Copy link
Contributor Author

/test-all

@gran-vmv
Copy link
Contributor Author

/test-all-features-conformance

@gran-vmv
Copy link
Contributor Author

/test-all

antoninbas
antoninbas reviewed Oct 20, 2021
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for one small comment

test/e2e/traceflow_test.go Outdated Show resolved Hide resolved
@gran-vmv
Copy link
Contributor Author

/test-all

antoninbas
antoninbas previously approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gran-vmv
Copy link
Contributor Author

Rebased to latest main branch.

@gran-vmv @antoninbas
[traceflow] Validate source Pod for non-live-traffic Traceflow
823b35a 
antrea-controller will update the status to "Failed" immediately if the
source is an invalid Pod or hostNetwork Pod for a non-live-traffic Traceflow.

Signed-off-by: gran <gran@vmware.com>

Co-authored-by: Antonin Bas <antonin.bas@gmail.com>
@gran-vmv
Copy link
Contributor Author

/test-all

@jianjuns jianjuns merged commit 12f8395 into antrea-io:main Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianjuns jianjuns jianjuns approved these changes

@edwardbadboy edwardbadboy Awaiting requested review from edwardbadboy

@antoninbas antoninbas Awaiting requested review from antoninbas

Assignees

@gran-vmv gran-vmv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gran-vmv @codecov-commenter @antoninbas @jianjuns