-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Bugfix: Agent crashed when removing the existing NetNat #2751
Conversation
Append "-Confirm:$false" in the powershell command "Remove-NetNat" for NonInteractive mode Signed-off-by: wenyingd <wenyingd@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #2751 +/- ##
==========================================
+ Coverage 60.62% 65.60% +4.98%
==========================================
Files 285 285
Lines 23033 26471 +3438
==========================================
+ Hits 13963 17366 +3403
+ Misses 7578 7476 -102
- Partials 1492 1629 +137
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-all |
/test-integration |
All Windows tests are passing |
@wenyingd please backport as appropriate (preferably all the way back to v0.13 if applicable) |
Append "-Confirm:$false" in the powershell command "Remove-NetNat" for NonInteractive mode
Fixes #2750
Signed-off-by: wenyingd wenyingd@vmware.com