Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Bugfix: Agent crashed when removing the existing NetNat #2751

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

wenyingd
Copy link
Contributor

@wenyingd wenyingd commented Sep 10, 2021

Append "-Confirm:$false" in the powershell command "Remove-NetNat" for NonInteractive mode

Fixes #2750

Signed-off-by: wenyingd wenyingd@vmware.com

Append "-Confirm:$false" in the powershell command "Remove-NetNat" for NonInteractive mode

Signed-off-by: wenyingd <wenyingd@vmware.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2021

Codecov Report

Merging #2751 (2f690b1) into main (767ed55) will increase coverage by 4.98%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2751      +/-   ##
==========================================
+ Coverage   60.62%   65.60%   +4.98%     
==========================================
  Files         285      285              
  Lines       23033    26471    +3438     
==========================================
+ Hits        13963    17366    +3403     
+ Misses       7578     7476     -102     
- Partials     1492     1629     +137     
Flag Coverage Δ
e2e-tests 57.19% <ø> (?)
kind-e2e-tests 48.38% <ø> (+0.04%) ⬆️
unit-tests 41.02% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/egress/ipallocator/allocator.go 65.00% <0.00%> (-15.42%) ⬇️
pkg/controller/networkpolicy/endpoint_querier.go 77.64% <0.00%> (-13.79%) ⬇️
pkg/legacyapis/core/v1alpha2/register.go 69.23% <0.00%> (-10.77%) ⬇️
pkg/apis/stats/register.go 71.42% <0.00%> (-10.39%) ⬇️
pkg/legacyapis/stats/register.go 71.42% <0.00%> (-10.39%) ⬇️
pkg/ovs/openflow/ofctrl_meter.go 33.84% <0.00%> (-10.16%) ⬇️
pkg/legacyapis/security/v1alpha1/register.go 73.33% <0.00%> (-10.00%) ⬇️
.../registry/networkpolicy/clustergroupmember/rest.go 78.26% <0.00%> (-9.98%) ⬇️
pkg/controller/egress/controller.go 74.55% <0.00%> (-9.58%) ⬇️
pkg/apiserver/handlers/endpoint/handler.go 61.11% <0.00%> (-9.48%) ⬇️
... and 269 more

Copy link
Contributor

@lzhecheng lzhecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyingd
Copy link
Contributor Author

/test-all
/skip-ipv6-all
/skip-ipv6-only-all

@wenyingd
Copy link
Contributor Author

/test-integration

@antoninbas
Copy link
Contributor

All Windows tests are passing

@antoninbas antoninbas merged commit 71b8b9d into antrea-io:main Sep 10, 2021
@antoninbas
Copy link
Contributor

@wenyingd please backport as appropriate (preferably all the way back to v0.13 if applicable)

@tnqn tnqn added the action/backport Indicates a PR that requires backports. label Jan 25, 2022
@wenyingd wenyingd deleted the windows_nonInteractive branch August 15, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/backport Indicates a PR that requires backports.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Agent crashed when removing an exisitng netnat
5 participants