Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chmod for OVSDB file from start_ovs #2803

Conversation

antoninbas
Copy link
Contributor

Starting with OVS 2.15.0, the permissions are set correctly (i.e. more
securely) for the OVSDB .db file (with no read permissions for
"others"). Because we use OVS 2.15.1 in Antrea, we no longer need to
manually fix the permissions in start_ovs / start_ovs_netdev.

Fixes #1292

Signed-off-by: Antonin Bas abas@vmware.com

Starting with OVS 2.15.0, the permissions are set correctly (i.e. more
securely) for the OVSDB .db file (with no read permissions for
"others"). Because we use OVS 2.15.1 in Antrea, we no longer need to
manually fix the permissions in start_ovs / start_ovs_netdev.

Fixes antrea-io#1292

Signed-off-by: Antonin Bas <abas@vmware.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2021

Codecov Report

Merging #2803 (1150122) into main (b0e2299) will decrease coverage by 20.39%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2803       +/-   ##
===========================================
- Coverage   61.49%   41.09%   -20.40%     
===========================================
  Files         284      157      -127     
  Lines       23549    19558     -3991     
===========================================
- Hits        14482     8038     -6444     
- Misses       7506    10757     +3251     
+ Partials     1561      763      -798     
Flag Coverage Δ
kind-e2e-tests ?
unit-tests 41.09% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/ovs/openflow/default.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/util/runtime/runtime.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/agent/cniserver/pod_configuration_linux.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/ovs/openflow/logs.go 9.52% <0.00%> (-90.48%) ⬇️
pkg/apis/controlplane/register.go 0.00% <0.00%> (-90.00%) ⬇️
pkg/agent/nodeportlocal/k8s/annotations.go 0.00% <0.00%> (-83.88%) ⬇️
pkg/agent/agent_linux.go 0.00% <0.00%> (-80.00%) ⬇️
pkg/agent/client.go 0.00% <0.00%> (-77.42%) ⬇️
pkg/ovs/ovsconfig/ovs_client_linux.go 0.00% <0.00%> (-76.93%) ⬇️
pkg/flowaggregator/certificate.go 0.00% <0.00%> (-76.58%) ⬇️
... and 230 more

@antoninbas
Copy link
Contributor Author

/test-all

@antoninbas
Copy link
Contributor Author

jenkins-windows-networkpolicy failed but this change doesn't affect windows

@antoninbas antoninbas merged commit c13aab5 into antrea-io:main Sep 21, 2021
@antoninbas antoninbas deleted the remove-chmod-for-ovsdb-file-from-start_ovs branch September 21, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restrict permissions for OVSDB (db.conf file) on each Node
3 participants