Ignore selected hostNetwork Pods in Egress groups #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jexf
force-pushed
the
egress-hostnetwork
branch
from
9e5b93e
to
d7b31e1
Compare
|
/test-all |
Jexf
force-pushed
the
egress-hostnetwork
branch
from
d7b31e1
to
f2a5447
Compare
|
/test-all |
antoninbas
reviewed
Sep 29, 2021
tnqn
reviewed
Sep 30, 2021
There was a problem hiding this comment.
Code LGTM. Same comment about commit title as @antoninbas has.
Now Egress does not support HostNetwork Pods, so need to ignore selected HostNetwork Pods in Egress groups. Signed-off-by: Wu zhengdong <zhengdong.wu@transwarp.io>
Jexf
force-pushed
the
egress-hostnetwork
branch
from
f2a5447
to
c3c4fe2
Compare
Jexf
changed the title
|
/test-all |
@tnqn Thanks for the review, updated. |
Codecov Report
@@ Coverage Diff @@
## main #2851 +/- ##
===========================================
+ Coverage 40.90% 65.97% +25.07%
===========================================
Files 158 284 +126
Lines 19539 26871 +7332
===========================================
+ Hits 7992 17729 +9737
+ Misses 10798 7477 -3321
- Partials 749 1665 +916
Flags with carried forward coverage won't be shown. Click here to find out more.
|
antoninbas
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now Egress does not support HostNetwork Pods, so need to ignore selected HostNetwork Pods in Egress groups.
Fixes: #2850
Signed-off-by: Wu zhengdong zhengdong.wu@transwarp.io