Improve ci/kind/kind-setup.sh usage #2937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jayunit100 PTAL |
Dyanngg
reviewed
Oct 26, 2021
antoninbas
force-pushed
the
improve-kind-setup.sh-usage
branch
3 times, most recently
from
6e9ac0c
to
98d6b73
Compare
Codecov Report
@@ Coverage Diff @@
## main #2937 +/- ##
===========================================
+ Coverage 40.19% 61.06% +20.86%
===========================================
Files 166 289 +123
Lines 20713 24551 +3838
===========================================
+ Hits 8326 14992 +6666
+ Misses 11574 7935 -3639
- Partials 813 1624 +811
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@jianjuns could I get a review on this? |
* Default "--antrea-cni" to false: most of the time, it is actually how we use it, and it is how users need to use the script. * Check-in build/yamls/antrea-kind.yml to avoid user confusion. * Improve Antrea with Kind documentation. Fixes antrea-io#2934 Signed-off-by: Antonin Bas <abas@vmware.com>
antoninbas
force-pushed
the
improve-kind-setup.sh-usage
branch
from
98d6b73
to
ee9762b
Compare
jianjuns
approved these changes
Nov 8, 2021
|
/skip-all |
qiyueyao
added a commit
to Dyanngg/antrea
that referenced
this pull request
Nov 9, 2021
This reverts commit 201e71b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we use it, and it is how users need to use the script.
Fixes #2934
Signed-off-by: Antonin Bas abas@vmware.com