[Multicast] Add multicast e2e tests #2986

ceclinux · 2021-11-05T02:09:21Z

No description provided.

codecov-commenter · 2021-11-05T02:24:47Z

Codecov Report

Merging #2986 (ab40a6c) into main (1b08a61) will decrease coverage by 8.16%.
The diff coverage is n/a.

❗ Current head ab40a6c differs from pull request most recent head e00e7aa. Consider uploading reports for the commit e00e7aa to get more accurate results

@@            Coverage Diff             @@
##             main    #2986      +/-   ##
==========================================
- Coverage   59.79%   51.63%   -8.17%     
==========================================
  Files         306      300       -6     
  Lines       26178    35724    +9546     
==========================================
+ Hits        15654    18447    +2793     
- Misses       8807    15527    +6720     
- Partials     1717     1750      +33

Flag	Coverage Δ
e2e-tests	`51.63% <ø> (?)`
kind-e2e-tests	`?`
unit-tests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/controller/egress/controller.go	`0.00% <0.00%> (-88.45%)`	⬇️
pkg/controller/networkpolicy/endpoint_querier.go	`4.58% <0.00%> (-86.85%)`	⬇️
pkg/agent/util/iptables/lock.go	`0.00% <0.00%> (-81.82%)`	⬇️
pkg/controller/ipam/antrea_ipam_controller.go	`0.00% <0.00%> (-80.29%)`	⬇️
pkg/controller/ipam/validate.go	`0.00% <0.00%> (-80.00%)`	⬇️
pkg/agent/cniserver/ipam/antrea_ipam_controller.go	`0.00% <0.00%> (-79.77%)`	⬇️
...kg/agent/flowexporter/connections/conntrack_ovs.go	`0.00% <0.00%> (-77.58%)`	⬇️
pkg/controller/externalippool/validate.go	`0.00% <0.00%> (-76.20%)`	⬇️
pkg/agent/cniserver/ipam/antrea_ipam.go	`3.47% <0.00%> (-75.70%)`	⬇️
pkg/cni/client.go	`0.00% <0.00%> (-75.52%)`	⬇️
... and 296 more

XinShuYang · 2021-12-14T01:58:55Z

/test-multicast-e2e

ceclinux · 2021-12-14T02:01:57Z

/test-multicast-e2e

ceclinux · 2021-12-15T05:58:18Z

/test-multicast-e2e

ceclinux · 2021-12-20T08:47:17Z

/test-multicast-e2e

ceclinux · 2021-12-20T10:07:37Z

/test-multicast-e2e

ceclinux · 2021-12-20T11:43:02Z

/test-multicast-e2e

ceclinux · 2021-12-20T11:55:03Z

/test-multicast-e2e

ceclinux · 2021-12-20T15:22:37Z

/test-multicast-e2e

ceclinux · 2021-12-20T15:47:18Z

/test-multicast-e2e

ceclinux · 2021-12-21T01:38:20Z

/test-multicast-e2e

ceclinux · 2021-12-21T02:14:03Z

/test-multicast-e2e

ceclinux · 2021-12-21T02:25:14Z

/test-multicast-e2e

ceclinux · 2021-12-21T02:35:12Z

/test-multicast-e2e

ceclinux · 2021-12-21T02:52:50Z

/test-multicast-e2e

ceclinux · 2021-12-21T14:06:42Z

/test-multicast-e2e

ceclinux · 2021-12-21T14:51:23Z

/test-multicast-e2e

ceclinux · 2021-12-22T03:22:23Z

/test-multicast-e2e

ceclinux · 2022-01-19T22:35:33Z

/test-multicast-e2e

ceclinux · 2022-01-19T23:01:56Z

/test-multicast-e2e

ceclinux · 2022-01-20T02:09:25Z

/test-multicast-e2e

ceclinux · 2022-01-20T03:28:52Z

/test-multicast-e2e

tnqn · 2022-01-20T06:04:15Z

test/e2e/framework.go

+		return []string{}, err
+	}
+	agentConfData := configMap.Data["antrea-agent.conf"]
+	for _, line := range strings.Split(agentConfData, "\n") {


var agentConf agentconfig.AgentConfig if err := yaml.Unmarshal([]byte(agentConfData, &agentConf); err != nil { return nil, fmt.Errorf("failed to unmarshal Agent config from ConfigMap: %v", err) } return agentConfData.MulticastInterfaces, nil

tnqn · 2022-01-20T06:32:04Z

test/e2e/multicast_test.go

+		if err != nil {
+			return nil, err
+		}
+		multicastInterfaces, err := data.GetMulticastInterfaces(antreaNamespace)


Move it to out of the loop as it's same for all Nodes.

tnqn · 2022-01-20T06:37:59Z

test/e2e/multicast_test.go

+		} else {
+			nodeIdx = workerIdx
+			workerIdx++
+		}


Maybe just iterate clusterInfo.nodes, all above code can be removed.

for i, node := range clusterInfo.nodes { _, localInterfacesStr, _, err := RunCommandOnNode(node.name, fmt.Sprintf("ls /sys/class/net")) ... }

tnqn · 2022-01-20T06:44:40Z

test/e2e/multicast_test.go

+}
+
+var nodeMulticastInterfaces [][]string
+var transportInterface string


avoid to define such gloabl variables, it should not be hard to pass them via arugments. They are easy to conflict in this package.

updated. removed

tnqn · 2022-01-20T06:48:38Z

test/e2e/multicast_test.go

+			break
+		}
+	}
+	if !multipleInterfacesTested {


t.Run("runTestMulticastForwardToMultipleInterfaces", func(t *testing.T) { multipleInterfacesFound := false var nodeIdx int for i, ifaces := range nodeMulticastInterfaces { if len(ifaces) >= 2 { multipleInterfacesFound = true nodeIdx = i break } } if !multipleInterfacesFound { t.Skip("Skipping test because none of the Nodes has more than one multicast enabled interface") } runTestMulticastForwardToMultipleInterfaces(t, data, nodeIdx, 3464, "224.3.4.13") })

To leverage the Skip method so that the test will be executed anyway and marked as skipped like other skipped tests.

ceclinux · 2022-01-20T08:24:46Z

/test-multicast-e2e

ceclinux · 2022-01-20T08:36:26Z

/test-multicast-e2e

ceclinux · 2022-01-20T09:00:13Z

/test-multicast-e2e

test/e2e/multicast_test.go

tnqn · 2022-01-20T09:04:20Z

test/e2e/multicast_test.go

+		}
+		return true, nil
+	}); err != nil {
+		t.Fatalf("Error when waiting for multicast routes and stats: %v", err)


It doesn't wait for multicast routes.

Signed-off-by: Ruochen Shen <src655@gmail.com>

ceclinux · 2022-01-20T09:31:16Z

/test-multicast-e2e

tnqn

LGTM

tnqn · 2022-01-20T11:31:14Z

/test-multicast-e2e
/test-e2e
/test-conformance
/test-networkpolicy

tnqn · 2022-01-20T15:00:54Z

/test-integration

tnqn · 2022-01-20T15:18:26Z

/test-integration

tnqn · 2022-01-20T15:40:06Z

/test-integration

tnqn · 2022-01-20T16:14:58Z

/skip-integration This PR has nothing to do with integration test but the check kept failing. I have ran the test manually and created #3213 to track the test issue.

Signed-off-by: Ruochen Shen <src655@gmail.com>

ceclinux mentioned this pull request Nov 5, 2021

Multicast route configuration and support for join/leave transport node #2835

Merged

ceclinux force-pushed the add_multicast_e2e_test branch from 4089dbd to 50b7ecd Compare December 20, 2021 10:04

ceclinux force-pushed the add_multicast_e2e_test branch from f226cc5 to 19d711a Compare December 20, 2021 11:54

ceclinux force-pushed the add_multicast_e2e_test branch from 19d711a to 3c93954 Compare December 20, 2021 15:46

ceclinux force-pushed the add_multicast_e2e_test branch from 3c93954 to 4223588 Compare December 21, 2021 02:13

ceclinux force-pushed the add_multicast_e2e_test branch from 4223588 to 33d696c Compare December 21, 2021 02:24

ceclinux force-pushed the add_multicast_e2e_test branch from 33d696c to bbd5eb1 Compare December 21, 2021 02:48

ceclinux force-pushed the add_multicast_e2e_test branch from bbd5eb1 to aa23e9f Compare December 21, 2021 14:06

ceclinux force-pushed the add_multicast_e2e_test branch from aa23e9f to 6f27d48 Compare December 21, 2021 14:51

ceclinux force-pushed the add_multicast_e2e_test branch from 6f27d48 to e1640ae Compare December 22, 2021 03:21

ceclinux force-pushed the add_multicast_e2e_test branch from e1640ae to e5e70c0 Compare December 24, 2021 03:07

ceclinux force-pushed the add_multicast_e2e_test branch from e5e70c0 to 48fbf2b Compare January 3, 2022 14:02

ceclinux force-pushed the add_multicast_e2e_test branch from fd7a796 to a503029 Compare January 19, 2022 22:35

ceclinux force-pushed the add_multicast_e2e_test branch 3 times, most recently from 9791ccd to 7312995 Compare January 20, 2022 02:08

ceclinux force-pushed the add_multicast_e2e_test branch from 7312995 to dc7aff5 Compare January 20, 2022 03:25

ceclinux force-pushed the add_multicast_e2e_test branch from dc7aff5 to 939cc22 Compare January 20, 2022 04:07

tnqn reviewed Jan 20, 2022

View reviewed changes

ceclinux force-pushed the add_multicast_e2e_test branch from 939cc22 to 4034e32 Compare January 20, 2022 08:20

tnqn reviewed Jan 20, 2022

View reviewed changes

[Multicast] Add Multicast e2e tests

e00e7aa

Signed-off-by: Ruochen Shen <src655@gmail.com>

ceclinux force-pushed the add_multicast_e2e_test branch from 4034e32 to 14758d1 Compare January 20, 2022 09:31

tnqn reviewed Jan 20, 2022

View reviewed changes

ceclinux force-pushed the add_multicast_e2e_test branch from 14758d1 to e00e7aa Compare January 20, 2022 10:40

tnqn approved these changes Jan 20, 2022

View reviewed changes

tnqn merged commit 839dc5c into antrea-io:main Jan 20, 2022

wenyingd mentioned this pull request Jan 21, 2022

Multicast Support in Antrea #2251

Closed

12 tasks

yanjunz97 pushed a commit to yanjunz97/antrea that referenced this pull request Feb 14, 2022

[Multicast] Add Multicast e2e tests (antrea-io#2986)

f97e8fb

Signed-off-by: Ruochen Shen <src655@gmail.com>

[Multicast] Add multicast e2e tests #2986

[Multicast] Add multicast e2e tests #2986

Conversation

ceclinux commented Nov 5, 2021 • edited Loading

codecov-commenter commented Nov 5, 2021 • edited Loading

Codecov Report

XinShuYang commented Dec 14, 2021

ceclinux commented Dec 14, 2021

ceclinux commented Dec 15, 2021

ceclinux commented Dec 20, 2021

ceclinux commented Dec 20, 2021

ceclinux commented Dec 20, 2021

ceclinux commented Dec 20, 2021

ceclinux commented Dec 20, 2021

ceclinux commented Dec 20, 2021

ceclinux commented Dec 21, 2021

ceclinux commented Dec 21, 2021

ceclinux commented Dec 21, 2021

ceclinux commented Dec 21, 2021

ceclinux commented Dec 21, 2021

ceclinux commented Dec 21, 2021

ceclinux commented Dec 21, 2021

ceclinux commented Dec 22, 2021

ceclinux commented Jan 19, 2022

ceclinux commented Jan 19, 2022

ceclinux commented Jan 20, 2022

ceclinux commented Jan 20, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ceclinux commented Jan 20, 2022

ceclinux commented Jan 20, 2022

ceclinux commented Jan 20, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ceclinux commented Jan 20, 2022

tnqn left a comment

Choose a reason for hiding this comment

tnqn commented Jan 20, 2022

tnqn commented Jan 20, 2022

tnqn commented Jan 20, 2022

tnqn commented Jan 20, 2022

tnqn commented Jan 20, 2022

ceclinux commented Nov 5, 2021 •

edited

Loading

codecov-commenter commented Nov 5, 2021 •

edited

Loading