Fix status report of Antrea-native policies #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-e2e |
Codecov Report
@@ Coverage Diff @@
## main #3074 +/- ##
==========================================
+ Coverage 59.79% 61.84% +2.05%
==========================================
Files 292 292
Lines 24732 34550 +9818
==========================================
+ Hits 14788 21369 +6581
- Misses 8317 11408 +3091
- Partials 1627 1773 +146
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tnqn
force-pushed
the
fix-netpol-status
branch
from
c1ce15c
to
0347c45
Compare
|
/test-all |
antoninbas
previously approved these changes
Dec 1, 2021
| c.policyMapLock.Lock() | ||
| defer c.policyMapLock.Unlock() | ||
| return c.updateNetworkPolicyLocked(policy) | ||
| } | ||
|
|
||
| func (c *ruleCache) updateNetworkPolicyLocked(policy *v1beta.NetworkPolicy) error { | ||
| func (c *ruleCache) updateNetworkPolicyLocked(policy *v1beta.NetworkPolicy) bool { |
There was a problem hiding this comment.
maybe add a function comment to explain what the return value stands for
tnqn
force-pushed
the
fix-netpol-status
branch
from
0347c45
to
32c4c34
Compare
For an Antrea-native policy with multiple rules that have different AppliedTo, some rules may not be effective on a Node when the policy applies to the Node. In this case, antrea-agent didn't make any actual dataplane change and didn't report new status to antrea-controller if the only changed part of a policy event is about the ineffective rules, even though the generation of the policy may have changed. This leads to a policy staying in realizing state because of the missing status report. This patch fixes it by triggering status report at least once as long as a policy is actually updated. In addition, it removes some useless return value and changes the order of event logs to better reflect the cause of policy reconciliation. Signed-off-by: Quan Tian <qtian@vmware.com>
tnqn
force-pushed
the
fix-netpol-status
branch
from
32c4c34
to
cde4d67
Compare
|
/test-all |
antoninbas
approved these changes
Dec 2, 2021
antoninbas
pushed a commit
that referenced
this pull request
Oct 20, 2022
For an Antrea-native policy with multiple rules that have different AppliedTo, some rules may not be effective on a Node when the policy applies to the Node. In this case, antrea-agent didn't make any actual dataplane change and didn't report new status to antrea-controller if the only changed part of a policy event is about the ineffective rules, even though the generation of the policy may have changed. This leads to a policy staying in realizing state because of the missing status report. This patch fixes it by triggering status report at least once as long as a policy is actually updated. In addition, it removes some useless return value and changes the order of event logs to better reflect the cause of policy reconciliation. Signed-off-by: Quan Tian <qtian@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an Antrea-native policy with multiple rules that have different AppliedTo, some rules may not be effective on a Node when the policy applies to the Node. In this case, antrea-agent didn't make any actual dataplane change and didn't report new status to antrea-controller if the only changed part of a policy event is about the ineffective rules, even though the generation of the policy may have changed. This leads to a policy staying in realizing state because of the missing status report.
This patch fixes it by triggering status report at least once as long as a policy is actually updated. In addition, it removes some useless return value and changes the order of event logs to better reflect the cause of policy reconciliation.
Signed-off-by: Quan Tian qtian@vmware.com
Fixes #3075