Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not group hostNetwork Pods in ClusterGroup/AddressGroup #3080

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

Dyanngg
Copy link
Contributor

@Dyanngg Dyanngg commented Dec 2, 2021

Fixes #3078

Signed-off-by: Yang Ding dingyang@vmware.com

Fixes antrea-io#3078

Signed-off-by: Yang Ding dingyang@vmware.com
Signed-off-by: Yang Ding <dingyang@vmware.com>
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll defer to @tnqn for final approval

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2021

Codecov Report

Merging #3080 (4ad2c0a) into main (b7da020) will increase coverage by 1.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3080      +/-   ##
==========================================
+ Coverage   59.79%   60.94%   +1.15%     
==========================================
  Files         292      292              
  Lines       24732    24732              
==========================================
+ Hits        14788    15074     +286     
+ Misses       8317     8011     -306     
- Partials     1627     1647      +20     
Flag Coverage Δ
kind-e2e-tests 48.14% <0.00%> (+1.31%) ⬆️
unit-tests 40.12% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntroller/networkpolicy/networkpolicy_controller.go 82.64% <100.00%> (ø)
pkg/apiserver/certificate/certificate.go 69.86% <0.00%> (-6.85%) ⬇️
pkg/controller/networkpolicy/status_controller.go 73.20% <0.00%> (-3.93%) ⬇️
pkg/agent/controller/networkpolicy/reject.go 84.67% <0.00%> (-3.23%) ⬇️
pkg/agent/cniserver/pod_configuration.go 53.33% <0.00%> (-0.40%) ⬇️
pkg/agent/openflow/client.go 57.76% <0.00%> (+0.65%) ⬆️
...ntroller/networkpolicy/networkpolicy_controller.go 71.34% <0.00%> (+0.91%) ⬆️
...kg/agent/flowexporter/connections/conntrack_ovs.go 77.57% <0.00%> (+1.21%) ⬆️
pkg/ovs/openflow/ofctrl_action.go 69.58% <0.00%> (+1.66%) ⬆️
.../flowexporter/connections/conntrack_connections.go 85.40% <0.00%> (+2.18%) ⬆️
... and 9 more

@Dyanngg
Copy link
Contributor Author

Dyanngg commented Dec 2, 2021

/test-all

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn tnqn merged commit fb57d91 into antrea-io:main Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hostNetwork Pods should be omitted from AddressGroups computed by antrea-controller
4 participants