Fix the AddressGroup duplicated deleted bug #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jexf
force-pushed
the
fix-delete-addressgroup
branch
from
e155616
to
60c12ec
Compare
|
/test-all |
Codecov Report
@@ Coverage Diff @@
## main #3136 +/- ##
===========================================
+ Coverage 40.35% 58.59% +18.24%
===========================================
Files 167 295 +128
Lines 20879 24907 +4028
===========================================
+ Hits 8426 14595 +6169
+ Misses 11632 8733 -2899
- Partials 821 1579 +758
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Jexf
force-pushed
the
fix-delete-addressgroup
branch
from
60c12ec
to
852a641
Compare
|
/test-integration |
|
nit: in the commit message "when generating AddressGroup keys from NetworkPolicy rules." |
Use sets instead of slice to resolve duplicated AddressGroup key problem when generating AddressGroup keys from NetworkPolicy rules. Signed-off-by: Wu zhengdong <zhengdong.wu@transwarp.io>
Jexf
force-pushed
the
fix-delete-addressgroup
branch
from
852a641
to
a1ea0c3
Compare
|
Jexf
added
the
area/network-policy/controller
|
/test-all |
|
@Jexf there are some issues with the CI this week, so all PRs are pending for merging. I will take care of merging it once it's back to normal. |
|
/skip-all I have validated the required checks manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use sets instead of slice to resolve duplicated AddressGroup key problem when generating AddressGroup keys from NetworkPolicy rules.
Fixes: #3135
Signed-off-by: Wu zhengdong zhengdong.wu@transwarp.io