Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to go-ipfix v0.5.12 #3352

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Conversation

yanjunz97
Copy link
Contributor

This commit adds changes in go-ipfix v0.5.12.

It fixes some issues leading to the unexpected burst in the throughput calculated in the flow aggregator.

Signed-off-by: Yanjun Zhou zhouya@vmware.com

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2022

Codecov Report

Merging #3352 (ac57a4e) into main (0e4bf90) will increase coverage by 12.69%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3352       +/-   ##
===========================================
+ Coverage   42.11%   54.81%   +12.69%     
===========================================
  Files         200      374      +174     
  Lines       24150    51262    +27112     
===========================================
+ Hits        10171    28098    +17927     
- Misses      12922    20725     +7803     
- Partials     1057     2439     +1382     
Flag Coverage Δ
e2e-tests 53.63% <66.66%> (?)
integration-tests 35.81% <ø> (?)
kind-e2e-tests 49.04% <50.00%> (?)
unit-tests 42.11% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/flowaggregator/flowaggregator.go 65.71% <0.00%> (+42.14%) ⬆️
pkg/ipfix/ipfix_intermediate.go 90.90% <100.00%> (ø)
pkg/controller/ipam/antrea_ipam_controller.go 48.71% <0.00%> (-31.57%) ⬇️
pkg/controller/networkpolicy/endpoint_querier.go 61.46% <0.00%> (-29.97%) ⬇️
pkg/controller/egress/controller.go 61.11% <0.00%> (-27.34%) ⬇️
pkg/agent/cniserver/ipam/antrea_ipam.go 55.55% <0.00%> (-23.62%) ⬇️
pkg/agent/cniserver/ipam/antrea_ipam_controller.go 55.93% <0.00%> (-23.59%) ⬇️
pkg/controller/ipam/validate.go 57.14% <0.00%> (-22.86%) ⬇️
pkg/agent/util/iptables/lock.go 60.00% <0.00%> (-21.82%) ⬇️
pkg/controller/externalippool/validate.go 55.17% <0.00%> (-21.02%) ⬇️
... and 337 more

Copy link
Contributor

@heanlan heanlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yanjun for the fix.

@@ -1,4 +1,4 @@
// Copyright 2021 Antrea Authors
// Copyright 2022 Antrea Authors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it need to be 2022?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to update the old copyright after this file was created.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one is updated by make codegen automatically.

Copy link
Contributor

@dreamtalen dreamtalen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanjunz97
Copy link
Contributor Author

/test-all

heanlan
heanlan previously approved these changes Feb 24, 2022
antoninbas
antoninbas previously approved these changes Feb 24, 2022
Signed-off-by: Yanjun Zhou <zhouya@vmware.com>
@yanjunz97
Copy link
Contributor Author

Got failures in TestClusterGroup after running Kind test for three times. Rebased the code to see if it improves.

@yanjunz97
Copy link
Contributor Author

/test-all
/test-ipv6-e2e
/test-ipv6-only-e2e

@yanjunz97
Copy link
Contributor Author

/test-integration

@yanjunz97
Copy link
Contributor Author

/test-all-features-conformance

@yanjunz97
Copy link
Contributor Author

All tests passed.

@antoninbas antoninbas merged commit b147eb2 into antrea-io:main Feb 28, 2022
bangqipropel pushed a commit to bangqipropel/antrea that referenced this pull request Mar 2, 2022
Signed-off-by: Yanjun Zhou <zhouya@vmware.com>
ksamoray pushed a commit to ksamoray/antrea that referenced this pull request Mar 3, 2022
Signed-off-by: Yanjun Zhou <zhouya@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants