Fix ipBlock referenced in nested ClusterGroup not processed correctly #3383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dyanngg
added
the
area/network-policy/controller
Dyanngg
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3383 +/- ##
==========================================
- Coverage 60.85% 53.64% -7.21%
==========================================
Files 266 239 -27
Lines 26520 34211 +7691
==========================================
+ Hits 16139 18353 +2214
- Misses 8591 14083 +5492
+ Partials 1790 1775 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tnqn
added
action/backport
tnqn
reviewed
Mar 2, 2022
pkg/apiserver/registry/networkpolicy/clustergroupmember/rest.go
Outdated
Show resolved
Hide resolved
|
/test-all |
|
/test-all |
tnqn
reviewed
Mar 4, 2022
| @@ -62,12 +62,11 @@ func (r *REST) Get(ctx context.Context, name string, options *metav1.GetOptions) | |||
| effectiveIPBlocks = append(effectiveIPBlocks, ipb.CIDR) | |||
| } | |||
| memberList.EffectiveIPBlocks = effectiveIPBlocks | |||
| } else { | |||
| effectiveMembers := make([]controlplane.GroupMember, 0, len(groupMembers)) | |||
There was a problem hiding this comment.
Is it still better to keep the code that allocates required size in one shot to be a bit more efficient?
There was a problem hiding this comment.
Of course. My bad. Fixed
Signed-off-by: Yang Ding <dingyang@vmware.com>
|
/test-all |
|
@Dyanngg could you backport this PR to previous releases if applicable? |
GraysonWu
pushed a commit
to GraysonWu/antrea
that referenced
this pull request
Mar 8, 2022
…ntrea-io#3383) Signed-off-by: Yang Ding <dingyang@vmware.com>
GraysonWu
pushed a commit
to GraysonWu/antrea
that referenced
this pull request
Mar 8, 2022
…ntrea-io#3383) Signed-off-by: Yang Ding <dingyang@vmware.com>
GraysonWu
pushed a commit
to GraysonWu/antrea
that referenced
this pull request
Mar 10, 2022
…ntrea-io#3383) Signed-off-by: Yang Ding <dingyang@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3376
Signed-off-by: Yang Ding dingyang@vmware.com