-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pkt mark conflict between HostLocalSourceMark and SNATIPMark #3430
Conversation
/test-all |
Codecov Report
@@ Coverage Diff @@
## main #3430 +/- ##
===========================================
+ Coverage 42.43% 59.88% +17.44%
===========================================
Files 200 268 +68
Lines 24295 26870 +2575
===========================================
+ Hits 10310 16090 +5780
+ Misses 12921 9018 -3903
- Partials 1064 1762 +698
Flags with carried forward coverage won't be shown. Click here to find out more.
|
HostLocalSourceMark is used to mark locally generated packets from Node net namespace, but it conflicted with bits used by SNATIPMark, leading to these packets being SNATed mistakenly when there happens to be an Egress using same mark. Fixes antrea-io#3431 Signed-off-by: Quan Tian <qtian@vmware.com>
a57a660
to
7c13f85
Compare
/test-all |
/test-ipv6-all |
/test-ipv6-only-e2e |
/test-ipv6-e2e |
@tnqn this test failed twice in a row for
|
Checked with @antoninbas, the test failure was introduced by #3336. We will fix it separately. Merging this one to unblock other PRs. |
…rea-io#3430) HostLocalSourceMark is used to mark locally generated packets from Node net namespace, but it conflicted with bits used by SNATIPMark, leading to these packets being SNATed mistakenly when there happens to be an Egress using same mark. Fixes antrea-io#3431 Signed-off-by: Quan Tian <qtian@vmware.com> (cherry picked from commit 045f342686ad042b2ffae4af3445e6e7d1dd7da1) (cherry picked from commit c71eb1302d6b4d7c55aaa5331586db3654369897)
Fix pkt mark conflict between HostLocalSourceMark and SNATIPMark (antrea-io#3430) See merge request tos/opensource/antrea!33
HostLocalSourceMark is used to mark locally generated packets from Node
net namespace, but it conflicted with bits used by SNATIPMark, leading
to these packets being SNATed mistakenly when there happens to be an
Egress using same mark.
Fixes #3431
Signed-off-by: Quan Tian qtian@vmware.com