-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ELK Flow Collector #3738
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3738 +/- ##
===========================================
- Coverage 64.60% 46.09% -18.51%
===========================================
Files 278 246 -32
Lines 39640 35914 -3726
===========================================
- Hits 25608 16556 -9052
- Misses 12043 17719 +5676
+ Partials 1989 1639 -350
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Provisions the Vagrant VMs. | ||
--ip-family <v4|v6|dual> Deploy IPv4, IPv6 or dual-stack Kubernetes cluster. | ||
--large Deploy large vagrant VMs with 2 vCPUs and 4096MB memory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could retain this option? Might be useful when deploying other memory-consuming stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with your point. My concern is currently the option is only used by ELK, and it's easy to add if we need it later. cc @antoninbas for opinions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to remove it. Less is more :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If so, we also need to remove these lines in Vagrantfile: https://github.com/antrea-io/antrea/blob/main/test/e2e/infra/vagrant/Vagrantfile#L38
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! removed
https://github.com/antrea-io/antrea/runs/6326239828?check_suite_focus=true |
@@ -983,165 +944,4 @@ by adding the file in the following section: | |||
./hack/generate-manifest-flow-visibility.sh > build/yamls/flow-visibility.yml | |||
``` | |||
|
|||
### ELK Flow Collector (deprecated) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe instead of removing this whole section, keep a disclaimer for a couple of releases. I think the whole section should be replaced with:
### ELK Flow Collector (removed)
**Starting with Antrea v1.7, support for the ELK Flow Collector has been removed.**
Please consider using the [Grafana Flow Collector](...) instead, which is actively maintained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a disclaimer as suggested, thanks
Provisions the Vagrant VMs. | ||
--ip-family <v4|v6|dual> Deploy IPv4, IPv6 or dual-stack Kubernetes cluster. | ||
--large Deploy large vagrant VMs with 2 vCPUs and 4096MB memory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to remove it. Less is more :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test-all |
This PR removes ELK Flow Collector's related files: 1. manifests under build/yamls/elk-flow-collector 2. jenkins CI validation job 3. quick deployment options in scripts 4. documentation Signed-off-by: heanlan <hanlan@vmware.com>
Signed-off-by: heanlan <hanlan@vmware.com>
/test-all |
/test-e2e |
/skip-network-policy |
Unrelated CI failures |
This PR removes ELK Flow Collector's related files:
Signed-off-by: heanlan hanlan@vmware.com