Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for Helm installation method #3989

Merged
merged 2 commits into from
Jul 12, 2022

Conversation

antoninbas
Copy link
Contributor

Fixes #2641

Signed-off-by: Antonin Bas abas@vmware.com

@antoninbas antoninbas added the kind/documentation Categorizes issue or PR as related to a documentation. label Jul 11, 2022
@antoninbas antoninbas force-pushed the add-helm-install-documentation branch from 2ac1383 to 3fb3278 Compare July 11, 2022 23:24
docs/helm.md Outdated Show resolved Hide resolved
docs/helm.md Show resolved Hide resolved
docs/helm.md Outdated Show resolved Hide resolved
docs/helm.md Outdated Show resolved Hide resolved
@antoninbas antoninbas force-pushed the add-helm-install-documentation branch from 216bb3b to 1ab56f0 Compare July 12, 2022 00:31
docs/helm.md Outdated Show resolved Hide resolved
@antoninbas antoninbas force-pushed the add-helm-install-documentation branch from 1ab56f0 to 784d187 Compare July 12, 2022 00:38
yanjunz97
yanjunz97 previously approved these changes Jul 12, 2022
Copy link
Contributor

@yanjunz97 yanjunz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jianjuns jianjuns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits.

docs/helm.md Outdated Show resolved Hide resolved
docs/helm.md Outdated Show resolved Hide resolved
to these CRDs). CRDs defined this way will also never be deleted (to avoid
accidental deletion of user-defined CRs) and will also never be upgraded (in
case the chart author didn't ensure that the upgrade was
backwards-compatible). The rationale for all of this is described in details in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this -> these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's "this" here

docs/helm.md Outdated Show resolved Hide resolved
Fixes antrea-io#2641

Signed-off-by: Antonin Bas <abas@vmware.com>
Signed-off-by: Antonin Bas <abas@vmware.com>
@antoninbas
Copy link
Contributor Author

/skip-all

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #3989 (33e175b) into main (33e175b) will not change coverage.
The diff coverage is n/a.

❗ Current head 33e175b differs from pull request most recent head c3d3e89. Consider uploading reports for the commit c3d3e89 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3989   +/-   ##
=======================================
  Coverage   64.39%   64.39%           
=======================================
  Files         295      295           
  Lines       43781    43781           
=======================================
  Hits        28191    28191           
  Misses      13304    13304           
  Partials     2286     2286           
Flag Coverage Δ
kind-e2e-tests 50.86% <0.00%> (ø)
unit-tests 44.24% <0.00%> (ø)

@antoninbas antoninbas merged commit b9f3426 into antrea-io:main Jul 12, 2022
@antoninbas antoninbas deleted the add-helm-install-documentation branch July 12, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to a documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart support
3 participants