Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform cleanup before running antrea-agent #4277

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

Anandkumar26
Copy link
Contributor

@Anandkumar26 Anandkumar26 commented Oct 10, 2022

Run cleanup before running antrea-agent service

Before running the antrea-agent, validate
whether ovs configuration is in good state.
If there is an error, cleanup ovs configuration
and then start antrea-agent.

Also fix typo and style issues.
Also update documentation.

Fixes #4122

Signed-off-by: Anand Kumar kumaranand@vmware.com

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #4277 (25d0fee) into main (0dceb75) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4277      +/-   ##
==========================================
- Coverage   63.17%   63.14%   -0.03%     
==========================================
  Files         388      388              
  Lines       55129    55145      +16     
==========================================
- Hits        34825    34823       -2     
- Misses      17731    17761      +30     
+ Partials     2573     2561      -12     
Flag Coverage Δ
integration-tests 34.42% <ø> (-0.02%) ⬇️
kind-e2e-tests 48.62% <ø> (-0.72%) ⬇️
unit-tests 45.06% <ø> (+0.50%) ⬆️
Impacted Files Coverage Δ
pkg/agent/cniserver/ipam/antrea_ipam.go 52.81% <0.00%> (-22.95%) ⬇️
pkg/agent/cniserver/ipam/ipam_service.go 76.40% <0.00%> (-12.36%) ⬇️
pkg/agent/controller/networkpolicy/reject.go 70.00% <0.00%> (-11.00%) ⬇️
pkg/agent/proxy/topology.go 72.72% <0.00%> (-9.10%) ⬇️
pkg/controller/externalippool/controller.go 86.16% <0.00%> (-6.25%) ⬇️
pkg/controller/networkpolicy/tier.go 50.00% <0.00%> (-5.00%) ⬇️
pkg/agent/openflow/service.go 88.42% <0.00%> (-3.16%) ⬇️
pkg/agent/memberlist/cluster.go 72.29% <0.00%> (-2.87%) ⬇️
pkg/agent/cniserver/ipam/antrea_ipam_controller.go 79.45% <0.00%> (-1.37%) ⬇️
pkg/controller/networkpolicy/status_controller.go 68.56% <0.00%> (-1.14%) ⬇️
... and 31 more

hack/externalnode/install-vm.ps1 Outdated Show resolved Hide resolved
hack/externalnode/install-vm.ps1 Outdated Show resolved Hide resolved
hack/externalnode/install-vm.sh Outdated Show resolved Hide resolved
hack/externalnode/install-vm.ps1 Outdated Show resolved Hide resolved
hack/externalnode/install-vm.sh Outdated Show resolved Hide resolved
hack/externalnode/install-vm.ps1 Outdated Show resolved Hide resolved
hack/externalnode/install-vm.ps1 Outdated Show resolved Hide resolved
hack/externalnode/install-vm.ps1 Show resolved Hide resolved
wenyingd
wenyingd previously approved these changes Oct 11, 2022
Copy link
Contributor

@wenyingd wenyingd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn tnqn added this to the Antrea v1.9 release milestone Oct 11, 2022
@Anandkumar26 Anandkumar26 changed the title Add antrea monitor service for cleanup. Perform cleanup before running antrea-agent Oct 13, 2022
@Anandkumar26 Anandkumar26 requested review from wenyingd and tnqn and removed request for wenyingd October 13, 2022 15:24
hack/externalnode/install-vm.ps1 Outdated Show resolved Hide resolved
hack/externalnode/install-vm.ps1 Outdated Show resolved Hide resolved
hack/externalnode/install-vm.ps1 Outdated Show resolved Hide resolved
hack/externalnode/install-vm.sh Outdated Show resolved Hide resolved
hack/externalnode/install-vm.sh Show resolved Hide resolved
Before running the antrea-agent, validate
whether ovs configuration is in good state.
If there is an error, cleanup ovs configuration
and then start antrea-agent.

Also fix typo and style issues.
Also update documentation.

Fixes antrea-io#4122

Signed-off-by: Anand Kumar <kumaranand@vmware.com>
Copy link
Contributor

@wenyingd wenyingd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnqn
Copy link
Member

tnqn commented Oct 17, 2022

/skip-networkpolicy
/skip-e2e
/skip-conformance

@tnqn tnqn merged commit c358373 into antrea-io:main Oct 17, 2022
@tnqn tnqn added the action/release-note Indicates a PR that should be included in release notes. label Oct 17, 2022
heanlan pushed a commit to heanlan/antrea that referenced this pull request Mar 29, 2023
Before running the antrea-agent, validate
whether ovs configuration is in good state.
If there is an error, cleanup ovs configuration
and then start antrea-agent.

Also fix typo and style issues.
Also update documentation.

Fixes antrea-io#4122

Signed-off-by: Anand Kumar <kumaranand@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/release-note Indicates a PR that should be included in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upon VM reboot antrea-agent does not work, OVS has invalid configuration
4 participants