Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remaining images to use ubuntu:22.04 base image #4499

Merged

Conversation

antoninbas
Copy link
Contributor

We also update the Vagrant-based test infra to use Ubuntu 22.04 as the Node OS. Because Ubuntu 22.04 ships with crgroup v2, we need to configure containerd to use the systemd cgroup driver.

Signed-off-by: Antonin Bas abas@vmware.com

We also update the Vagrant-based test infra to use Ubuntu 22.04 as the
Node OS. Because Ubuntu 22.04 ships with crgroup v2, we need to
configure containerd to use the systemd cgroup driver.

Signed-off-by: Antonin Bas <abas@vmware.com>
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #4499 (790fca4) into main (656a1f9) will decrease coverage by 1.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4499      +/-   ##
==========================================
- Coverage   69.78%   68.01%   -1.78%     
==========================================
  Files         379      403      +24     
  Lines       55438    57729    +2291     
==========================================
+ Hits        38688    39264     +576     
- Misses      14081    15752    +1671     
- Partials     2669     2713      +44     
Flag Coverage Δ
e2e-tests 38.68% <ø> (?)
integration-tests 34.64% <ø> (+0.05%) ⬆️
kind-e2e-tests 46.87% <ø> (+0.17%) ⬆️
unit-tests 56.71% <ø> (-1.39%) ⬇️
Impacted Files Coverage Δ
...nt/apiserver/handlers/serviceexternalip/handler.go 29.62% <0.00%> (-22.23%) ⬇️
pkg/ovs/ovsctl/ovsctl_others.go 53.84% <0.00%> (-12.83%) ⬇️
pkg/controller/networkpolicy/crd_utils.go 81.71% <0.00%> (-11.87%) ⬇️
pkg/agent/flowexporter/exporter/exporter.go 71.53% <0.00%> (-10.15%) ⬇️
pkg/agent/consistenthash/consistenthash.go 93.75% <0.00%> (-3.75%) ⬇️
pkg/agent/apiserver/apiserver.go 71.27% <0.00%> (-3.20%) ⬇️
pkg/agent/controller/networkpolicy/reject.go 73.55% <0.00%> (-2.89%) ⬇️
pkg/agent/controller/networkpolicy/packetin.go 70.27% <0.00%> (-2.71%) ⬇️
pkg/controller/grouping/controller.go 65.13% <0.00%> (-1.98%) ⬇️
.../flowexporter/connections/conntrack_connections.go 80.47% <0.00%> (-0.96%) ⬇️
... and 55 more

@gran-vmv
Copy link
Contributor

/test-e2e
/test-flexible-ipam-e2e
/test-ipv6-e2e
/test-ipv6-only-e2e

@gran-vmv
Copy link
Contributor

/test-flexible-ipam-e2e
/test-ipv6-e2e
/test-ipv6-only-e2e

1 similar comment
@gran-vmv
Copy link
Contributor

/test-flexible-ipam-e2e
/test-ipv6-e2e
/test-ipv6-only-e2e

Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gran-vmv
Copy link
Contributor

/test-e2e
/test-ipv6-e2e

@gran-vmv
Copy link
Contributor

/test-flexible-ipam-e2e

1 similar comment
@gran-vmv
Copy link
Contributor

/test-flexible-ipam-e2e

@antoninbas
Copy link
Contributor Author

/test-ipv6-e2e

1 similar comment
@antoninbas
Copy link
Contributor Author

/test-ipv6-e2e

@antoninbas
Copy link
Contributor Author

The dual-stack IPv6 test is failing consistently. I believe this is because of a recently-added test. I opened #4502.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants