Update Multi-cluster user guide #4889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luolanzone
added
kind/documentation
antoninbas
reviewed
Apr 20, 2023
docs/multicluster/user-guide.md
Outdated
|
|
||
| | Pod-to-Pod connectivity provided by underlay | Gateway Enabled | MC EndpointTypes | Cross-cluster Service/Pod communications | | ||
| | -------------------------------------------- | --------------- | ----------------- | ---------------------------------------- | | ||
| | No | No | ClusterIP(default)| No | |
There was a problem hiding this comment.
I don't understand the MC EndpointTypes for this one. I thought MC Services would not work in this case (no cross-cluster Service traffic).
There was a problem hiding this comment.
Yes, it won't work, changed it to None.
I was thinking there is no 'None' type of EndpointTypes before.
luolanzone
force-pushed
the
update-mc-doc
branch
from
a43e392
to
042db0e
Compare
antoninbas
reviewed
Apr 24, 2023
docs/multicluster/user-guide.md
Outdated
| @@ -81,6 +81,12 @@ antrea-agent.conf: | | |||
| namespace: "" # Change to the Namespace where antrea-mc-controller is deployed. | |||
| ``` | |||
|
|
|||
| In order for Multi-cluster features to work, `enableGateway` should be set to true by the user, | |||
There was a problem hiding this comment.
I was reading this again, and I think a small improvment could be:
In order for Multi-cluster features to work, it is necessary for
enableGatewayto be set to true by the user,
docs/multicluster/user-guide.md
Outdated
|
|
||
| | Pod-to-Pod connectivity provided by underlay | Gateway Enabled | MC EndpointTypes | Cross-cluster Service/Pod communications | | ||
| | -------------------------------------------- | --------------- | ----------------- | ---------------------------------------- | | ||
| | No | No | None | No | |
There was a problem hiding this comment.
If you think it is better, you can replace "None" with "N/A"
There was a problem hiding this comment.
Updated, thanks.
antoninbas
reviewed
Apr 24, 2023
Update Multi-cluster user guide to provide more details for Gateway enablement. Signed-off-by: Lan Luo <luola@vmware.com>
luolanzone
force-pushed
the
update-mc-doc
branch
from
042db0e
to
fc44d71
Compare
antoninbas
approved these changes
Apr 25, 2023
|
/skip-all |
jainpulkit22
pushed a commit
to urharshitha/antrea
that referenced
this pull request
Apr 28, 2023
Update Multi-cluster user guide to provide more details for Gateway enablement. Signed-off-by: Lan Luo <luola@vmware.com>
ceclinux
pushed a commit
to ceclinux/antrea
that referenced
this pull request
Jun 5, 2023
Update Multi-cluster user guide to provide more details for Gateway enablement. Signed-off-by: Lan Luo <luola@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Multi-cluster user guide to provide more details for Gateway enablement.