-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Multicast] Add Support for FlexibleIPAM #4922
Conversation
62c63b0
to
a6fdaf3
Compare
b8b1d72
to
68a54a5
Compare
/test-multicast-e2e |
/test-flexible-ipam-e2e |
1 similar comment
/test-flexible-ipam-e2e |
668cdd0
to
ca3179a
Compare
/test-multicast-e2e |
1 similar comment
/test-multicast-e2e |
/test-flexible-ipam-e2e |
1 similar comment
/test-flexible-ipam-e2e |
/test-multicast-e2e |
bb7f642
to
59bf237
Compare
pkg/agent/openflow/pipeline.go
Outdated
// send multicast packets to access the external receivers. For the case that one or more local Pods have joined the target | ||
// multicast group, it is handled by the flows created by function "localMulticastForwardFlows" after local Pods report the | ||
// IGMP membership. | ||
// externalMulticastReceiverFlow generates the flow to output multicast packets to Antrea gateway interface(to the host interface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// externalMulticastReceiverFlow generates the flow to output multicast packets to Antrea gateway interface(to the host interface | |
// externalMulticastReceiverFlow generates the flow to output multicast packets to Antrea gateway interface (and the host interface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Personally, I think in the parentheses, the phrase to the host interface and the uplink interface when flexibleIPAM is enabled
is more reasonable to me.
59bf237
to
3a5fae9
Compare
3a5fae9
to
fe594a7
Compare
/test-multicast-e2e |
/test-flexible-ipam-e2e |
fe594a7
to
ccc30e9
Compare
/test-multicast-e2e |
/test-flexible-ipam-e2e |
When FlexibleIPAM is enabled for the cluster. Inbound multicast traffic will be forwarded to MulticastRoutingTable. Outbound multicast traffic will forward to local ports, the uplink interface, and the host interface. Signed-off-by: ceclinux <src655@gmail.com>
ccc30e9
to
92e4648
Compare
/test-flexible-ipam-e2e |
/test-multicast-e2e |
Hi @tnqn . Could you take time to have another look? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/skip-all |
When FlexibleIPAM is enabled for the cluster, inbound multicast traffic will
be forwarded to MulticastRoutingTable. Outbound multicast traffic will
forward to local ports, the uplink interface, and the host interface.