Refine "antctl mc deploy" command #5080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug that when user deploys Antrea Multi-cluster via `antctl mc` on EKS clusters, user can't create ClusterSet and ClusterClaims with an error like below: ``` Internal error occurred: failed calling webhook "vclusterclaim.kb.io": failed to call webhook: ... x509: certificate signed by unknown authority ``` It's caused by a slow deployment when using `antctl mc deploy`, antrea-mc-controller is running but validation webhook configuration is not created yet, the `cabundle` in the webhook configuration won't be updated. It turns out `GetAPIGroupResources` is a time-consuming step and it's also unnecessary to be called every time in a loop, so move it out to the caller with a few other refinements to fix the bug. Signed-off-by: Lan Luo <luola@vmware.com>
|
/test-multicluster-e2e |
luolanzone
added
action/backport
jianjuns
approved these changes
Jun 6, 2023
jianjuns
changed the title
|
@jianjuns could you help to move forward? Thanks. |
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug that when user deploys Antrea Multi-cluster via
antctl mcon EKS clusters, user can't create ClusterSet and ClusterClaims with an error like below:It's caused by a slow deployment when using
antctl mc deploy, that antrea-mc-controller is running but the validation webhook configuration is not created yet, and thecabundlein the webhook configuration won't be updated. It turns outGetAPIGroupResourcesis a time-consuming step and it is also unnecessary to be called every time in a loop, so this commit moves it out to the caller with a few other refinements to fix the issue.