Fix incorrect FlowMod message passing in openflow client modifyFlows #5125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dyanngg
requested review from
wenyingd,
tnqn,
GraysonWu,
hongliangl and
luolanzone
Dyanngg
added
kind/bug
hongliangl
reviewed
Jun 14, 2023
| @@ -450,10 +450,10 @@ func (c *client) modifyFlows(cache *flowCategoryCache, flowCacheKey string, flow | |||
| var msg *openflow15.FlowMod | |||
| if _, ok := oldFlowCache[matchString]; ok { | |||
| msg = getFlowModMessage(flow, binding.ModifyMessage) | |||
| adds = append(adds, msg) | |||
| mods = append(mods, msg) | |||
Signed-off-by: Dyanngg <dingyang@vmware.com>
Yes it seems to be the case.
In my own dev testing (for a feature that's unrelated to released ones), I found out that because of this bug, OVS will fail to add specific flows explicitly passed to the client in update cases, and throw no openflow errors. I added the backport tag because it seems the function is used in |
wenyingd
approved these changes
Jun 15, 2023
|
/test-all |
tnqn
approved these changes
Jun 16, 2023
tnqn
added
the
action/release-note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the openflow client, the
modifyFlowsfunction incorrectly flipped theaddandmodtype ofFlowModmessages that it passes to the lower levelBundleOpsoperation. This could lead to unexpected openflow state for the caller.